Skip to content

Commit 083bfc9

Browse files
Deprecate colour $nhsuk-border-hover-colour (duplicated)
1 parent 3c66d52 commit 083bfc9

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

packages/nhsuk-frontend/src/nhsuk/components/card/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
$nhsuk-card-border-width: 1px;
3636
$nhsuk-card-border-bottom-width: nhsuk-spacing(1);
3737
$nhsuk-card-border-colour: $nhsuk-border-colour;
38-
$nhsuk-card-border-hover-colour: $nhsuk-border-hover-colour;
38+
$nhsuk-card-border-hover-colour: $nhsuk-secondary-border-colour;
3939

4040
// @deprecated To be removed in v11.0
4141
$card-border-width: $nhsuk-card-border-width;

packages/nhsuk-frontend/src/nhsuk/components/details/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
$nhsuk-expander-border-width: 1px;
2323
$nhsuk-expander-border-bottom-width: nhsuk-spacing(1);
2424
$nhsuk-expander-border-colour: $nhsuk-border-colour;
25-
$nhsuk-expander-border-hover-colour: $nhsuk-border-hover-colour;
25+
$nhsuk-expander-border-hover-colour: $nhsuk-secondary-border-colour;
2626
$nhsuk-expander-icon-size: 27px; // 19px font size + 4px summary text padding
2727

2828
// @deprecated To be removed in v11.0

packages/nhsuk-frontend/src/nhsuk/core/core.unit.test.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ describe('Core', () => {
5151
--nhsuk-error-colour: #d5281b;
5252
--nhsuk-success-colour: #007f3b;
5353
--nhsuk-border-colour: #d8dde0;
54-
--nhsuk-border-hover-colour: #aeb7bd;
5554
--nhsuk-secondary-border-colour: #aeb7bd;
5655
--nhsuk-reverse-border-colour: #337ec6;
56+
--nhsuk-border-hover-colour: #aeb7bd;
5757
--nhsuk-input-border-colour: #4c6272;
5858
--nhsuk-hover-colour: #aeb7bd;
5959
--nhsuk-input-background-colour: white;

packages/nhsuk-frontend/src/nhsuk/core/settings/_colours-applied.scss

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,6 @@ $nhsuk-success-colour: nhsuk-colour("green") !default;
107107

108108
$nhsuk-border-colour: nhsuk-colour("grey-4") !default;
109109

110-
/// Border hover colour
111-
///
112-
/// @type Colour
113-
114-
$nhsuk-border-hover-colour: nhsuk-colour("grey-3") !default;
115-
116110
/// Secondary border colour
117111
///
118112
/// @type Colour
@@ -125,6 +119,14 @@ $nhsuk-secondary-border-colour: nhsuk-colour("grey-3") !default;
125119

126120
$nhsuk-reverse-border-colour: nhsuk-tint($nhsuk-brand-colour, 20%) !default;
127121

122+
/// Border hover colour
123+
///
124+
/// @alias $nhsuk-secondary-border-colour
125+
/// @deprecated To be removed in v11.0, replaced by $nhsuk-secondary-border-colour
126+
/// @type Colour
127+
128+
$nhsuk-border-hover-colour: $nhsuk-secondary-border-colour;
129+
128130
/// Form border colour
129131
///
130132
/// Used for form inputs and controls

0 commit comments

Comments
 (0)