Skip to content

Commit 9d3c296

Browse files
committed
refactor: streamline excluded_urls handling and remove redundant code
1 parent 0ed7895 commit 9d3c296

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

instrumentation/opentelemetry-instrumentation-httpx/pyproject.toml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,6 @@ dependencies = [
3737
instruments = [
3838
"httpx >= 0.18.0",
3939
]
40-
test = [
41-
"opentelemetry-instrumentation-httpx[instruments]",
42-
"opentelemetry-sdk ~= 1.12",
43-
"opentelemetry-test-utils == 0.42b0.dev",
44-
"httpretty ~= 1.0",
45-
]
4640

4741
[project.entry-points.opentelemetry_instrumentor]
4842
httpx = "opentelemetry.instrumentation.httpx:HTTPXClientInstrumentor"

instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -604,9 +604,6 @@ async def handle_async_request(
604604

605605
if self._excluded_urls and self._excluded_urls.url_disabled(url):
606606
return await self._transport.handle_async_request(*args, **kwargs)
607-
608-
if context.get_value("suppress_instrumentation"):
609-
return await self._transport.handle_async_request(*args, **kwargs)
610607

611608
method_original = method.decode()
612609
span_name = _get_default_span_name(method_original)
@@ -715,11 +712,11 @@ def _instrument(self, **kwargs: typing.Any):
715712
else None
716713
)
717714

718-
excluded_urls = kwargs.get("excluded_urls")
719-
if excluded_urls is None:
720-
excluded_urls = _excluded_urls_from_env
721-
else:
722-
excluded_urls = parse_excluded_urls(excluded_urls)
715+
excluded_urls = (
716+
parse_excluded_urls(excluded_urls)
717+
if kwargs.get("excluded_urls")
718+
else _excluded_urls_from_env
719+
)
723720

724721
_OpenTelemetrySemanticConventionStability._initialize()
725722
sem_conv_opt_in_mode = _OpenTelemetrySemanticConventionStability._get_opentelemetry_stability_opt_in_mode(
@@ -927,6 +924,7 @@ def instrument_client(
927924
tracer_provider: TracerProvider | None = None,
928925
request_hook: RequestHook | AsyncRequestHook | None = None,
929926
response_hook: ResponseHook | AsyncResponseHook | None = None,
927+
excluded_urls: ExcludeList | None = None,
930928
) -> None:
931929
"""Instrument httpx Client or AsyncClient
932930
@@ -980,6 +978,7 @@ def instrument_client(
980978
sem_conv_opt_in_mode=sem_conv_opt_in_mode,
981979
request_hook=request_hook,
982980
response_hook=response_hook,
981+
excluded_urls=excluded_urls,
983982
),
984983
)
985984
for transport in client._mounts.values():
@@ -993,6 +992,7 @@ def instrument_client(
993992
sem_conv_opt_in_mode=sem_conv_opt_in_mode,
994993
request_hook=request_hook,
995994
response_hook=response_hook,
995+
excluded_urls=excluded_urls,
996996
),
997997
)
998998
client._is_instrumented_by_opentelemetry = True
@@ -1006,6 +1006,7 @@ def instrument_client(
10061006
sem_conv_opt_in_mode=sem_conv_opt_in_mode,
10071007
async_request_hook=async_request_hook,
10081008
async_response_hook=async_response_hook,
1009+
excluded_urls=excluded_urls,
10091010
),
10101011
)
10111012
for transport in client._mounts.values():
@@ -1019,6 +1020,7 @@ def instrument_client(
10191020
sem_conv_opt_in_mode=sem_conv_opt_in_mode,
10201021
async_request_hook=async_request_hook,
10211022
async_response_hook=async_response_hook,
1023+
excluded_urls=excluded_urls,
10221024
),
10231025
)
10241026
client._is_instrumented_by_opentelemetry = True

0 commit comments

Comments
 (0)