Fix incorrect reporting of non-ASCII characters in the measurement display name (#1093)

* Read the serviceconfig using utf-8 encoding

* Add unit test and support SBOM.

* Fix client generation with localized service config and default values.

* Remove protobuf color enum & fix lint errors

---------

Co-authored-by: Jonathan Lugo <[email protected]>

Author: jonlugoatx

packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py

@@ -52,7 +52,7 @@ def _create_file(
         mode=black.Mode(line_length=100),
     )
 
-    with output_file.open("w") as file:
+    with output_file.open("w", encoding="utf-8") as file:
         file.write(formatted_output)
 
 

packages/generator/tests/acceptance/test_client_generator.py

@@ -14,6 +14,7 @@
     non_streaming_data_measurement,
     streaming_data_measurement,
     void_measurement,
+    localized_measurement,
 )
 
 
@@ -79,6 +80,37 @@ def test___void_measurement___create_client___render_without_error(
     )
 
 
+def test___localized_measurement___create_client___render_without_error(
+    create_client: CliRunnerFunction,
+    test_assets_directory: pathlib.Path,
+    tmp_path_factory: pytest.TempPathFactory,
+    localized_measurement_service: MeasurementService,
+) -> None:
+    temp_directory = tmp_path_factory.mktemp("measurement_plugin_client_files")
+    module_name = "localized_measurement_client"
+    golden_path = test_assets_directory / "example_renders" / "measurement_plugin_client"
+    filename = f"{module_name}.py"
+
+    result = create_client(
+        [
+            "--measurement-service-class",
+            "ni.tests.LocalizedMeasurement_Python",
+            "--module-name",
+            module_name,
+            "--class-name",
+            "LocalizedMeasurementClient",
+            "--directory-out",
+            str(temp_directory),
+        ]
+    )
+
+    assert result.exit_code == 0
+    _assert_equal(
+        golden_path / filename,
+        temp_directory / filename,
+    )
+
+
 def test___all_registered_measurements___create_client___renders_without_error(
     create_client: CliRunnerFunction,
     tmp_path_factory: pytest.TempPathFactory,
@@ -197,8 +229,8 @@ def test___non_streaming_measurement___create_client___render_without_mypy_error
 
 
 def _assert_equal(expected_path: pathlib.Path, result_path: pathlib.Path) -> None:
-    expected = expected_path.read_text()
-    result = result_path.read_text()
+    expected = expected_path.read_text(encoding="utf-8")
+    result = result_path.read_text(encoding="utf-8")
 
     assert expected == result
 
@@ -235,6 +267,15 @@ def void_measurement_service(
         yield service
 
 
+@pytest.fixture
+def localized_measurement_service(
+    discovery_service_process: DiscoveryServiceProcess,
+) -> Generator[MeasurementService, None, None]:
+    """Test fixture that creates and hosts a localized Measurement Plug-In Service."""
+    with localized_measurement.measurement_service.host_service() as service:
+        yield service
+
+
 @pytest.fixture
 def multiple_measurement_service(
     discovery_service_process: DiscoveryServiceProcess,