Remove support for Python 3.8 (#1076)

bkeryan · web-flow · commit d13a15296f55 · 2025-03-06T09:24:25.000-06:00
* Remove support for Python 3.8

* Remove Python 3.8 workarounds

* Fix lint errors
diff --git a/.github/workflows/run_unit_tests.yml b/.github/workflows/run_unit_tests.yml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest, ubuntu-latest]
-        python-version: [3.8, 3.9, '3.10', 3.11, 3.12]
+        python-version: [3.9, '3.10', 3.11, 3.12]
       # Fail-fast skews the pass/fail ratio and seems to make pytest produce
       # incomplete JUnit XML results.
       fail-fast: false
diff --git a/examples/game_of_life/pyproject.toml b/examples/game_of_life/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that displays Conway's Game of Life i
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 click = ">=7.1.2, !=8.1.4" # mypy fails with click 8.1.4: https://github.com/pallets/click/issues/2558
 
diff --git a/examples/nidaqmx_analog_input/pyproject.toml b/examples/nidaqmx_analog_input/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that performs a finite analog input m
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 nidaqmx = { version = ">=0.8.0", extras = ["grpc"] }
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 click = ">=7.1.2, !=8.1.4" # mypy fails with click 8.1.4: https://github.com/pallets/click/issues/2558
diff --git a/examples/nidcpower_source_dc_voltage/pyproject.toml b/examples/nidcpower_source_dc_voltage/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that sources and measures a DC voltag
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 nidcpower = { version = ">=1.4.4", extras = ["grpc"] }
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 click = ">=7.1.2, !=8.1.4" # mypy fails with click 8.1.4: https://github.com/pallets/click/issues/2558
diff --git a/examples/nidcpower_source_dc_voltage_with_multiplexer/pyproject.toml b/examples/nidcpower_source_dc_voltage_with_multiplexer/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that sources and measures a DC voltag
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 nidcpower = { version = ">=1.4.4", extras = ["grpc"] }
 niswitch = { version = ">=1.4.4", extras = ["grpc"] }
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
diff --git a/examples/nidigital_spi/pyproject.toml b/examples/nidigital_spi/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that tests a SPI device using an NI D
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 nidigital = { version = ">=1.4.4", extras = ["grpc"] }
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 click = ">=7.1.2, !=8.1.4" # mypy fails with click 8.1.4: https://github.com/pallets/click/issues/2558
diff --git a/examples/nidmm_measurement/pyproject.toml b/examples/nidmm_measurement/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that performs a measurement using an
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 nidmm = { version = ">=1.4.4", extras = ["grpc"] }
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 click = ">=7.1.2, !=8.1.4" # mypy fails with click 8.1.4: https://github.com/pallets/click/issues/2558
diff --git a/examples/nifgen_standard_function/pyproject.toml b/examples/nifgen_standard_function/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that generates a standard function wa
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 nifgen = { version = ">=1.4.4", extras = ["grpc"] }
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 click = ">=7.1.2, !=8.1.4" # mypy fails with click 8.1.4: https://github.com/pallets/click/issues/2558
diff --git a/examples/niscope_acquire_waveform/pyproject.toml b/examples/niscope_acquire_waveform/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that acquires a waveform using an NI
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 niscope = { version = ">=1.4.4", extras = ["grpc"] }
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 click = ">=7.1.2, !=8.1.4" # mypy fails with click 8.1.4: https://github.com/pallets/click/issues/2558
diff --git a/examples/niswitch_control_relays/pyproject.toml b/examples/niswitch_control_relays/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that controls relays using an NI rela
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 niswitch = { version = ">=1.4.4", extras = ["grpc"] }
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 click = ">=7.1.2, !=8.1.4" # mypy fails with click 8.1.4: https://github.com/pallets/click/issues/2558
diff --git a/examples/nivisa_dmm_measurement/pyproject.toml b/examples/nivisa_dmm_measurement/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that performs a DMM measurement using
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 PyVISA = "^1.13.0"
 PyVISA-sim = "^0.5.1"
diff --git a/examples/output_voltage_measurement/measurement.py b/examples/output_voltage_measurement/measurement.py
@@ -1,4 +1,4 @@
-""" Source DC voltage as input with an NI SMU and measure output using NI-VISA DMM."""
+"""Source DC voltage as input with an NI SMU and measure output using NI-VISA DMM."""
 
 import logging
 import pathlib
diff --git a/examples/output_voltage_measurement/pyproject.toml b/examples/output_voltage_measurement/pyproject.toml
@@ -6,7 +6,7 @@ description = ""
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 ni-measurement-plugin-sdk-service = {version = "^2.2.0"}
 PyVISA = "^1.13.0"
 PyVISA-sim = "^0.5.1"
diff --git a/examples/sample_measurement/pyproject.toml b/examples/sample_measurement/pyproject.toml
@@ -6,7 +6,7 @@ description = "Measurement plug-in example that performs a loopback measurement
 authors = ["National Instruments"]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 ni-measurement-plugin-sdk-service = {version = "^2.3.0-dev0", allow-prereleases = true}
 click = ">=7.1.2, !=8.1.4" # mypy fails with click 8.1.4: https://github.com/pallets/click/issues/2558
 
diff --git a/packages/generator/README.md b/packages/generator/README.md
@@ -22,7 +22,7 @@ Measurement Plug-In SDK Generator for Python (`ni-measurement-plugin-sdk-generat
 
 ## Dependencies
 
-- Python >= 3.8 [(3.9 recommended)](https://www.python.org/downloads/release/python-3913/)
+- [Python >= 3.9](https://www.python.org/downloads/release/python-3913/)
 - [mako >= 1.2.1, < 2.x](https://pypi.org/project/Mako/1.2.1/)
 - [click >= 8.1.3](https://pypi.org/project/click/8.1.3/)
 
diff --git a/packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py b/packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
@@ -4,7 +4,6 @@
 import keyword
 import pathlib
 import re
-import sys
 from enum import Enum
 from typing import AbstractSet, Dict, Iterable, List, Optional, Tuple, Type, TypeVar
 
@@ -455,10 +454,7 @@ def _remove_suffix(string: str) -> str:
     suffixes = ["_Python", "_LabVIEW", "_NET"]
     for suffix in suffixes:
         if string.endswith(suffix):
-            if sys.version_info >= (3, 9):
-                return string.removesuffix(suffix)
-            else:
-                return string[0 : len(string) - len(suffix)]
+            return string.removesuffix(suffix)
     return string
 
 
diff --git a/packages/generator/poetry.lock b/packages/generator/poetry.lock
diff --git a/packages/generator/pyproject.toml b/packages/generator/pyproject.toml
@@ -19,7 +19,7 @@ classifiers = [
 ]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 Mako = "^1.2.1"
 click = ">=8.1.3"
 grpcio = "^1.49.1"
@@ -42,7 +42,7 @@ ni-measurement-plugin-sdk-service = {path = "../../packages/service", develop =
 bandit = { version = ">=1.7", extras = ["toml"] }
 tox = ">=4.0"
 grpcio-tools = [
-  {version = "1.49.1", python = ">=3.8,<3.12"},
+  {version = "1.49.1", python = ">=3.9,<3.12"},
   {version = "1.59.0", python = "^3.12"},
 ]
 
diff --git a/packages/generator/tox.ini b/packages/generator/tox.ini
@@ -5,7 +5,7 @@
 
 [tox]
 isolated_build = true
-envlist = clean, py{38,39,310,311,312}
+envlist = clean, py{39,310,311,312}
 
 [testenv]
 skip_install = true
diff --git a/packages/sdk/README.md b/packages/sdk/README.md
@@ -16,7 +16,7 @@ For installation and usage, see [Measurement Plug-In SDK Service for Python (`ni
 
 ## Dependencies
 
-- Python >= 3.8 [(3.9 recommended)](https://www.python.org/downloads/release/python-3913/)
+- [Python >= 3.9](https://www.python.org/downloads/release/python-3913/)
 - [mako >= 1.2.1, < 2.x](https://pypi.org/project/Mako/1.2.1/)
 - [click >= 8.1.3](https://pypi.org/project/click/8.1.3/)
 
diff --git a/packages/sdk/poetry.lock b/packages/sdk/poetry.lock
diff --git a/packages/sdk/pyproject.toml b/packages/sdk/pyproject.toml
@@ -19,7 +19,7 @@ classifiers = [
 ]
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 ni-measurement-plugin-sdk-service = "*"
 ni-measurement-plugin-sdk-generator = "*"
 
diff --git a/packages/service/README.md b/packages/service/README.md
@@ -34,9 +34,9 @@ InstrumentStudio and automated testing in TestStand.
 
 ## Dependencies
 
-- Python >= 3.8 [(3.9 recommended)](https://www.python.org/downloads/release/python-3913/)
+- [Python >= 3.9](https://www.python.org/downloads/release/python-3913/)
 - [grpcio >= 1.49.1, < 2.x](https://pypi.org/project/grpcio/1.49.1/)
-- [protobuf >= 4.21, < 5.x](https://pypi.org/project/protobuf/4.21.0/)
+- [protobuf >= 4.21](https://pypi.org/project/protobuf/4.21.0/)
 - [pywin32 >= 303 (Only for Windows)](https://pypi.org/project/pywin32/303/)
 
 ---
diff --git a/packages/service/ni_measurement_plugin_sdk_service/_dotenvpath.py b/packages/service/ni_measurement_plugin_sdk_service/_dotenvpath.py
@@ -1,7 +1,7 @@
 import inspect
 import sys
 import traceback
-from pathlib import Path, PurePath
+from pathlib import Path
 from typing import Optional
 
 
@@ -44,7 +44,7 @@ def _get_caller_path() -> Optional[Path]:
     for frame, _ in traceback.walk_stack(inspect.currentframe()):
         if frame.f_code.co_filename:
             module_path = Path(frame.f_code.co_filename)
-            if _exists(module_path) and not _is_relative_to(module_path, nims_path):
+            if _exists(module_path) and not module_path.is_relative_to(nims_path):
                 return module_path
 
     return None
@@ -65,21 +65,6 @@ def _exists(path: Path) -> bool:
         return os.path.exists(path)
 
 
-if sys.version_info >= (3, 9):
-
-    def _is_relative_to(path: PurePath, other: PurePath) -> bool:
-        return path.is_relative_to(other)
-
-else:
-
-    def _is_relative_to(path: PurePath, other: PurePath) -> bool:
-        try:
-            _ = path.relative_to(other)
-            return True
-        except ValueError:
-            return False
-
-
 def _get_nims_path() -> Path:
     """Get the path of the ni_measurement_plugin_sdk_service package."""
     nims_module = sys.modules["ni_measurement_plugin_sdk_service"]
diff --git a/packages/service/poetry.lock b/packages/service/poetry.lock
diff --git a/packages/service/pyproject.toml b/packages/service/pyproject.toml
diff --git a/packages/service/tox.ini b/packages/service/tox.ini
