Skip to content

Commit 4e91b15

Browse files
committed
benchmarks: Fix buffer size
Samps per chan already takes num_channels into account.
1 parent 4771be1 commit 4e91b15

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

tests/benchmark/conftest.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@
2626
_WAVEFORM_BENCHMARK_MODE_IDS = ["NONE", "TIMING", "ALL"]
2727

2828

29-
def _configure_timing(task: Task, num_channels: int, num_samples: int) -> None:
29+
def _configure_timing(task: Task, num_samples: int) -> None:
3030
task.timing.cfg_samp_clk_timing(
3131
rate=25000.0,
3232
active_edge=Edge.RISING,
3333
sample_mode=AcquisitionType.FINITE,
34-
samps_per_chan=num_channels * num_samples * 2,
34+
samps_per_chan=num_samples * 2,
3535
)
3636

3737

@@ -41,8 +41,8 @@ def _start_input_task(task: Task) -> None:
4141
task.in_stream.relative_to = ReadRelativeTo.FIRST_SAMPLE
4242

4343

44-
def _commit_output_task(task: Task, num_channels: int, num_samples: int) -> None:
45-
task.out_stream.output_buf_size = num_channels * num_samples * 2
44+
def _commit_output_task(task: Task, num_samples: int) -> None:
45+
task.out_stream.output_buf_size = num_samples * 2
4646
task.control(TaskMode.TASK_COMMIT)
4747
task.out_stream.relative_to = ReadRelativeTo.FIRST_SAMPLE
4848

@@ -79,7 +79,7 @@ def ai_benchmark_task(
7979
max_val=5.0,
8080
)
8181

82-
_configure_timing(task, num_channels, num_samples)
82+
_configure_timing(task, num_samples)
8383
_start_input_task(task)
8484

8585
return task
@@ -102,8 +102,8 @@ def ao_benchmark_task(
102102
max_val=10.0,
103103
)
104104

105-
_configure_timing(task, num_channels, num_samples)
106-
_commit_output_task(task, num_channels, num_samples)
105+
_configure_timing(task, num_samples)
106+
_commit_output_task(task, num_samples)
107107

108108
return task
109109

@@ -129,7 +129,7 @@ def di_lines_benchmark_task(
129129
physical_channel_string, line_grouping=LineGrouping.CHAN_FOR_ALL_LINES
130130
)
131131

132-
_configure_timing(task, num_channels, num_samples)
132+
_configure_timing(task, num_samples)
133133
_start_input_task(task)
134134

135135
return task
@@ -149,7 +149,7 @@ def di_port32_benchmark_task(
149149
benchmark_device.di_ports[0].name, line_grouping=LineGrouping.CHAN_FOR_ALL_LINES
150150
)
151151

152-
_configure_timing(task, 1, num_samples)
152+
_configure_timing(task, num_samples)
153153
_start_input_task(task)
154154

155155
return task
@@ -176,8 +176,8 @@ def do_lines_benchmark_task(
176176
physical_channel_string, line_grouping=LineGrouping.CHAN_FOR_ALL_LINES
177177
)
178178

179-
_configure_timing(task, num_channels, num_samples)
180-
_commit_output_task(task, num_channels, num_samples)
179+
_configure_timing(task, num_samples)
180+
_commit_output_task(task, num_samples)
181181

182182
return task
183183

@@ -196,7 +196,7 @@ def do_port32_benchmark_task(
196196
benchmark_device.do_ports[0].name, line_grouping=LineGrouping.CHAN_FOR_ALL_LINES
197197
)
198198

199-
_configure_timing(task, 1, num_samples)
200-
_commit_output_task(task, 1, num_samples)
199+
_configure_timing(task, num_samples)
200+
_commit_output_task(task, num_samples)
201201

202202
return task

0 commit comments

Comments
 (0)