Skip to content

Commit ebd61c2

Browse files
authored
Revert workaround that skip docs tox env (#887)
* reproduce docs tox env fail issue * changelod
1 parent d295d69 commit ebd61c2

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

.github/workflows/run_system_tests.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ jobs:
1717
# Fail-fast skews the pass/fail ratio and seems to make pytest produce
1818
# incomplete JUnit XML results.
1919
fail-fast: false
20-
env:
21-
# Work around https://github.com/ni/nidaqmx-python/issues/862 - docs tox
22-
# env fails on rdss-nidaqmxbot-win-10-py32
23-
tox-args: ${{ matrix.configuration == 'win-10-py32' && '--skip-env docs' || '' }}
2420
timeout-minutes: 90
2521
steps:
2622
- name: Check out repo
@@ -41,7 +37,7 @@ jobs:
4137
- name: Install dependencies
4238
run: poetry install
4339
- name: Run system tests
44-
run: poetry run tox ${{ env.tox-args }}
40+
run: poetry run tox
4541
- name: Rename test results
4642
# TODO: Add Git Bash to the path on self-hosted Windows runners
4743
run: Get-ChildItem test_results/*.xml | Rename-Item -NewName { $_.Name -replace '.xml','-${{ matrix.configuration }}.xml' }

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ All notable changes to this project will be documented in this file.
3131

3232
* ### Resolved Issues
3333
* [820: Create a synchronization example for TDMS logging](https://github.com/ni/nidaqmx-python/issues/820)
34+
* [862: docs tox env fails on rdss-nidaqmxbot-win-10-py32](https://github.com/ni/nidaqmx-python/issues/862)
3435

3536
* ### Major Changes
3637
* Removed support for Python 3.9.

0 commit comments

Comments
 (0)