[RFC] nidaqmx: Add new version of event registration methods #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Keryan <[email protected]>
1 task
maxxboehme
reviewed
Jan 19, 2024
|
|
||
| self._interpreter.register_done_event(self._handle, 0, invoke_callback, None) | ||
|
|
||
| def register_every_n_samples_acquired_into_buffer_event_ex( |
Collaborator
There was a problem hiding this comment.
Make sure to update this example and any others that are registering callbacks to the new versions.
Collaborator
|
Closing this old PR. If anybody is interesting in contributing a feature like this, we can open a new one and have a discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
This is a prototype of an updated event signature that I made in May 2023.
Why should this Pull Request be merged?
It's an RFC and shouldn't be merged in its current form.
What testing has been done?
TODO: Detail what testing has been done to ensure this submission meets requirements.