Update tests to require X Series device with 32 DIO lines #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests and fixtures now require a real X Series device with at least 32 digital I/O lines, using the new real_x_series_device_32dio fixture. The _x_series_device helper accepts a line_number parameter for flexible device selection. Minor formatting and assertion changes included.
Contributor
Collaborator
|
(I know this is a draft :)) @YiQingTan - please fill in the PR description. Also, you have linting errors: |
Introduce new pytest fixtures for DI loopback tasks on ports 0, 1, and 2 for both standard and 32 DIO devices. Update the test function to use the 32 DIO-specific fixtures and assertions. Refactor test code to ensure correct fixture usage for each device type.
zhindes
approved these changes
Jun 10, 2025
bkeryan
approved these changes
Jun 10, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestions
The parameter line_number in _x_series_device and its usages has been renamed to min_num_lines to better reflect its purpose as the minimum number of digital lines required. This change affects both the function definition and its call in the real_x_series_device_32dio fixture. No logic was altered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] I've updated CHANGELOG.md if applicable.- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Tests and fixtures now can select a real X Series device with at least 32 digital I/O lines, using the new real_x_series_device_32dio fixture. The _x_series_device helper accepts a line_number parameter for flexible device selection.
Why should this Pull Request be merged?
This PR aims to fix #629, as well as failures reported in the ATS machine - MIO MiniTS 1. The error occurred because the real X series device used for the test does not support 32 lines. Hence, this PR is needed so that the fixture can filter out and use real X series devices that do support 32 lines.
What testing has been done?
Ran
poetry run toxin ATS machine - MIO MiniTS 1, and tests are now passing.