-
Notifications
You must be signed in to change notification settings - Fork 188
Add AnalogMultiChannelReader.read_waveforms() #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AnalogMultiChannelReader.read_waveforms() #801
Conversation
@mikeprosserni I don't know what happened here. Try rerunning failed jobs. |
|
Actually, since this PR was ready first, I'll merge the other way. |
@bkeryan I retried twice, and it failed all three times. |
@mikeprosserni @mshafer-NI setup-poetry is building dulwich (which includes optional Rust extensions) from source and poetry install is failing with error 0xC0000135 (STATUS_DLL_NOT_FOUND). It seems like these might be related. We're planning to upgrade ni/python-actions/setup-poetry to use Poetry 2.x by default soon. I'll see if that fixes this. Edit: also, yesterday's builds like https://github.com/ni/nidaqmx-python/actions/runs/16970490210/job/48105927969 used Python 3.13.5 but this build used Python 3.13.6. |
|
@mikeprosserni @mshafer-NI It still fails with Poetry 2.1.3: https://github.com/ni/nidaqmx-python/actions/runs/17000915019/job/48202416338?pr=802 Now I think the problem is that the venv cache key is not using the full Python version, so upgrading from 3.13.5 to 3.13.6 didn't invalidate the cache. |
|
…-3233518-analog-multi-read-waveform
|
@mikeprosserni That fixed it. I merged main into this PR's branch. |
I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
AnalogMultiChannelReader.read_waveforms()LibraryInterpreter.read_analog_waveforms()and.internal_read_analog_waveform_per_chan()Why should this Pull Request be merged?
Users want to be able to read multiple waveforms at once.
What testing has been done?