-
Notifications
You must be signed in to change notification settings - Fork 188
Adopt ni-python-styleguide for hand-written code #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ark, or exclamation point
Collaborator
Author
|
@zhindes To review this, you're probably better off looking at individual commits. Also, let's rebase this rather than squash it. |
Collaborator
Author
|
FYI @mikeprosserni This may cause some merge conflicts, but hopefully you're done with the big refactors. |
Contributor
zhindes
approved these changes
Sep 14, 2025
Collaborator
Yep that was very easy, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Enable
ni-python-styleguideforsrc/handwritten.Fix about 600/800 style errors and use
nps acknowledge-existing-violations --aggressiveto add noqas for the remaining ~200.Why should this Pull Request be merged?
I am sick of reviewing new code with style guide violations.
Closes #556
What testing has been done?
Ran
poetry run nps lint