Fix _convert_to_desired_timezone loses hightime accuracy for DST conversions #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lau-yeexuan
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
zhindes
approved these changes
Oct 23, 2025
bkeryan
requested changes
Oct 23, 2025
bkeryan
reviewed
Oct 23, 2025
bkeryan
reviewed
Oct 23, 2025
lau-yeexuan
force-pushed
the
users/yelau/fix_DST_conversion_hightime_accuracy
branch
from
74bb521 to
d84aa84
Compare
bkeryan
approved these changes
Oct 24, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestions
lau-yeexuan
force-pushed
the
users/yelau/fix_DST_conversion_hightime_accuracy
branch
from
fffe205 to
6462c37
Compare
Collaborator
Author
Collaborator
Oops, I forgot about https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches when I updated the required checks. |
auto-merge was automatically disabled
October 28, 2025 16:09
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
I've added tests applicable for this pull request
What does this Pull Request accomplish?
Preserve hightime accuracy for DST conversions in _convert_to_desired_timezone.
Add a test for DST with femtoseconds.
Why should this Pull Request be merged?
Fixes #860
#AB3439749
What testing has been done?
mypy passes