Remove WAVEFORM_SUPPORT feature toggle

[mikeprosserni]

• This contribution adheres to CONTRIBUTING.md.
• I've updated CHANGELOG.md if applicable.
• I've added tests applicable for this pull request

What does this Pull Request accomplish?

Now that all the read waveform and write waveform methods have full support for grpc-device, we can remove the WAVEFORM_SUPPORT feature toggle.

Why should this Pull Request be merged?

AB#3424643

What testing has been done?

Ran all the auto tests

Ran all the affected input examples

[github-actions]

Test Results

    42 files  ±  0      42 suites  ±0   1h 3m 38s ⏱️ -37s
 3 095 tests  -  24   2 532 ✅  -   8    563 💤  -  16  0 ❌ ±0 
51 040 runs   - 408  41 664 ✅  - 136  9 376 💤  - 272  0 ❌ ±0 

Results for commit 97fd445. ± Comparison against base commit b97ffcd.

This pull request removes 24 tests.

tests.component.stream_readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_waveforms_feature_disabled___raises_feature_not_supported_error[grpc_init_kwargs]
tests.component.stream_readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_waveforms_feature_disabled___raises_feature_not_supported_error[library_init_kwargs]
tests.component.stream_readers.test_analog_single_channel_reader ‑ test___analog_single_channel_reader___read_waveform_feature_disabled___raises_feature_not_supported_error[grpc_init_kwargs]
tests.component.stream_readers.test_analog_single_channel_reader ‑ test___analog_single_channel_reader___read_waveform_feature_disabled___raises_feature_not_supported_error[library_init_kwargs]
tests.component.stream_readers.test_digital_multi_channel_reader ‑ test___digital_multi_channel_multi_line_reader___read_waveforms_feature_disabled___raises_feature_not_supported_error[grpc_init_kwargs]
tests.component.stream_readers.test_digital_multi_channel_reader ‑ test___digital_multi_channel_multi_line_reader___read_waveforms_feature_disabled___raises_feature_not_supported_error[library_init_kwargs]
tests.component.stream_readers.test_digital_single_channel_reader ‑ test___digital_single_line_reader___read_waveform_feature_disabled___raises_feature_not_supported_error[grpc_init_kwargs]
tests.component.stream_readers.test_digital_single_channel_reader ‑ test___digital_single_line_reader___read_waveform_feature_disabled___raises_feature_not_supported_error[library_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_feature_disabled___raises_feature_not_supported_error[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_feature_disabled___raises_feature_not_supported_error[library_init_kwargs]
…

[bkeryan]

It's too early for this. Read https://dev.azure.com/ni/DevCentral/_wiki/wikis/AppCentral.wiki/900/Feature-Toggles

Feature toggles should only be removed once the code protected behind the feature toggle ships in the enabled state. Do not remove a feature toggle before the code ships.

[mikeprosserni]

Ah, I didn't know that policy was the same for GitHub repos, but it makes sense. I'll abandon this PR for now. Also, I'll change the work item from "remove the feature toggle" to "enable the feature toggle by default".

[bkeryan]

I don't want to break compatibility after release. If AB#3178052 is not fixed by release, then I think we should disable the waveform feature toggle.

    # Note, the data on the port's waveform is MSB instead of LSB because of bug AB#3178052
    # When that bug is fixed, these asserts should be updated

[mikeprosserni]

I've added AB#3178052 as a prerequisite for the "enable the waveform feature toggle" work item AB#3367327.

[bkeryan]

The parent bullet is unnecessary and only matters to developers, not users.

[mikeprosserni]

We can't remove this feature toggle until after release.