Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Dec 17, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

cont_dig_port_int_clk.py

  • Add a comment about the walking 1's pattern
  • Generate data based on chan.do_num_lines instead of hardcoding it
  • Print the data.

cont_dig_port_int_clk_wfm.py

  • Use a walking 1's pattern like the other example.
  • Use DigitalWaveform.from_port instead of setting the data for each line.
  • Save the result of add_do_chan instead of hardcoding the channel index.

Why should this Pull Request be merged?

I think a walking 1's pattern is a better example and connectivity test than binary counting because it toggles each line in an unambiguous order. Binary counting with a small number of samples does not toggle every line. The current implementation duplicates the count for each byte to cover more lines, but this would hide byte swapping.

What testing has been done?

Ran both examples on a PCIe-6353 connected to two BNC-2120s.

@github-actions
Copy link
Contributor

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3f28156.

@bkeryan
Copy link
Collaborator Author

bkeryan commented Dec 17, 2025

cont_gen_dig_port_int_clk.py

Writing data:
sample  0: 0x00000001
sample  1: 0x00000002
sample  2: 0x00000004
sample  3: 0x00000008
sample  4: 0x00000010
sample  5: 0x00000020
sample  6: 0x00000040
sample  7: 0x00000080
sample  8: 0x00000100
sample  9: 0x00000200
sample 10: 0x00000400
sample 11: 0x00000800
sample 12: 0x00001000
sample 13: 0x00002000
sample 14: 0x00004000
sample 15: 0x00008000
sample 16: 0x00010000
sample 17: 0x00020000
sample 18: 0x00040000
sample 19: 0x00080000
sample 20: 0x00100000
sample 21: 0x00200000
sample 22: 0x00400000
sample 23: 0x00800000
sample 24: 0x01000000
sample 25: 0x02000000
sample 26: 0x04000000
sample 27: 0x08000000
sample 28: 0x10000000
sample 29: 0x20000000
sample 30: 0x40000000
sample 31: 0x80000000
Generating voltage continuously. Press Enter to stop.

@bkeryan
Copy link
Collaborator Author

bkeryan commented Dec 17, 2025

cont_gen_dig_port_int_clk_wfm.py

Writing data:
line  0: [1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line  1: [0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line  2: [0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line  3: [0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line  4: [0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line  5: [0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line  6: [0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line  7: [0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line  8: [0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line  9: [0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 10: [0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 11: [0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 12: [0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 13: [0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 14: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 15: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 16: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 17: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 18: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0]
line 19: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0]
line 20: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0]
line 21: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0]
line 22: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0]
line 23: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0]
line 24: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0]
line 25: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0]
line 26: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0]
line 27: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0]
line 28: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0]
line 29: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0]
line 30: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0]
line 31: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1]
Generating voltage continuously. Press Enter to stop.

@bkeryan
Copy link
Collaborator Author

bkeryan commented Dec 17, 2025

@zhindes @mikeprosserni Both examples look like this:

20251217_180847000_iOS.MOV

link (replace hxxps with https): hxxps://github.com/user-attachments/assets/96e25bc1-392f-4cc7-a028-089da2b67b2b

@bkeryan bkeryan enabled auto-merge (squash) December 17, 2025 18:46
@bkeryan bkeryan merged commit 5276c7d into master Dec 17, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants