-
Notifications
You must be signed in to change notification settings - Fork 188
examples: Revise cont dig port output examples #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 3f28156. |
zhindes
approved these changes
Dec 17, 2025
Collaborator
Author
|
cont_gen_dig_port_int_clk.py |
Collaborator
Author
|
cont_gen_dig_port_int_clk_wfm.py |
mikeprosserni
approved these changes
Dec 17, 2025
Collaborator
Author
|
@zhindes @mikeprosserni Both examples look like this: 20251217_180847000_iOS.MOVlink (replace hxxps with https): hxxps://github.com/user-attachments/assets/96e25bc1-392f-4cc7-a028-089da2b67b2b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
cont_dig_port_int_clk.py
chan.do_num_linesinstead of hardcoding itcont_dig_port_int_clk_wfm.py
DigitalWaveform.from_portinstead of setting the data for each line.add_do_chaninstead of hardcoding the channel index.Why should this Pull Request be merged?
I think a walking 1's pattern is a better example and connectivity test than binary counting because it toggles each line in an unambiguous order. Binary counting with a small number of samples does not toggle every line. The current implementation duplicates the count for each byte to cover more lines, but this would hide byte swapping.
What testing has been done?
Ran both examples on a PCIe-6353 connected to two BNC-2120s.