Skip to content

Commit 6d4d58f

Browse files
authored
Update to latest versions of FAST packages and remove eslint rule disallowing ?? in templates (#2851)
# Pull Request ## 🤨 Rationale See #2025 for background.
1 parent c1c61fa commit 6d4d58f

File tree

9 files changed

+297
-133
lines changed

9 files changed

+297
-133
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Update fast-element and fast-foundation dependencies",
4+
"packageName": "@ni/nimble-components",
5+
"email": "1588923+rajsite@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Update fast-element and fast-foundation dependencies",
4+
"packageName": "@ni/ok-components",
5+
"email": "1588923+rajsite@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Update fast-element and fast-foundation dependencies",
4+
"packageName": "@ni/spright-components",
5+
"email": "1588923+rajsite@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

package-lock.json

Lines changed: 268 additions & 119 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/eslint-config-nimble/components.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,6 @@ export const componentsNimbleConfig = defineConfig([
8080
{
8181
files: ['**/template.ts'],
8282
rules: {
83-
// Using '??' in templates does not get flagged correctly by FAST as being a volatile binding.
84-
// See https://github.com/ni/nimble/issues/1843 for more information.
85-
'no-restricted-syntax': [
86-
'error',
87-
{ selector: "LogicalExpression[operator='??']" },
88-
],
8983
// eslint handle does not handle indent well in template files
9084
'@stylistic/indent': 'off',
9185
},

packages/nimble-components/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@
4242
"homepage": "https://github.com/ni/nimble#readme",
4343
"dependencies": {
4444
"@ni/fast-colors": "^10.0.0",
45-
"@ni/fast-element": "^10.0.0",
46-
"@ni/fast-foundation": "^10.1.2",
45+
"@ni/fast-element": "^10.1.0",
46+
"@ni/fast-foundation": "^10.1.5",
4747
"@ni/fast-web-utilities": "^10.0.0",
4848
"@ni/nimble-tokens": "^8.14.0",
4949
"@ni/unit-format": "^1.0.2",

packages/ok-components/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
},
3535
"homepage": "https://github.com/ni/nimble#readme",
3636
"dependencies": {
37-
"@ni/fast-element": "^10.0.0",
38-
"@ni/fast-foundation": "^10.1.2",
37+
"@ni/fast-element": "^10.1.0",
38+
"@ni/fast-foundation": "^10.1.5",
3939
"@ni/fast-web-utilities": "^10.0.0",
4040
"@ni/nimble-components": "^35.1.1",
4141
"@ni/spright-components": "^6.6.1",

packages/spright-components/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
},
3535
"homepage": "https://github.com/ni/nimble#readme",
3636
"dependencies": {
37-
"@ni/fast-element": "^10.0.0",
38-
"@ni/fast-foundation": "^10.1.2",
37+
"@ni/fast-element": "^10.1.0",
38+
"@ni/fast-foundation": "^10.1.5",
3939
"@ni/fast-web-utilities": "^10.0.0",
4040
"@ni/nimble-components": "^35.1.1",
4141
"tslib": "^2.2.0"

packages/storybook/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
"devDependencies": {
2525
"@chromatic-com/storybook": "^4.1.3",
2626
"@ni-private/eslint-config-nimble": "*",
27-
"@ni/fast-element": "^10.0.0",
28-
"@ni/fast-foundation": "^10.1.1",
27+
"@ni/fast-element": "^10.1.0",
28+
"@ni/fast-foundation": "^10.1.5",
2929
"@ni/fast-web-utilities": "^10.0.0",
3030
"@ni/nimble-components": "*",
3131
"@ni/nimble-react": "*",

0 commit comments

Comments
 (0)