-
Notifications
You must be signed in to change notification settings - Fork 11
Closed as not planned
Closed as not planned
Copy link
Labels
Description
🧹 Tech Debt
The current renovate configuration for NI dependencies (i.e. @ni/fast-* but potentially also eslint config, etc) does a lockfile only change instead of bumping the version in package.json, see:
Lines 63 to 77 in 2706d74
| "groupName": "npm NI dependencies update to latest", | |
| "matchManagers": [ | |
| "npm" | |
| ], | |
| "rangeStrategy": "update-lockfile", | |
| "matchDepTypes": [ | |
| "dependencies", | |
| "devDependencies", | |
| "peerDependencies" | |
| ], | |
| "matchPackageNames": "@ni/**", | |
| "schedule": [ | |
| "at any time" | |
| ] | |
| }, |
We should instead configure it to bump the package.json versions so that a release of nimble will cause adopters to pick-up the latest version (instead right now it's a transitive dependency that may not need to be picked up).
This will require running npm run change to create change files for the PRs instead of lock file only changes that were previously merged directly.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done