Moving the common lines in complex matchers into a function

Author: rahulr-NI

build/templates/_matchers.py.mako

@@ -283,6 +283,15 @@ class ViReal64PointerMatcher(_PointerMatcher):
 
 
 % if are_complex_parameters_used:
+def _compare_complex_number_arrays(expected, actual):
+    for i in range(expected.expected_size):
+        expected_value = expected.expected_data[i]
+        actual_value = actual[i]
+        if expected_value.real != actual_value.real or expected_value.imag != actual_value.imag:
+            return False
+    return True
+
+
 class NIComplexNumberPointerMatcher(_PointerMatcher):
     def __init__(self, expected_data, expected_size):
         _PointerMatcher.__init__(self, _complextype.NIComplexNumber)
@@ -291,13 +300,7 @@ class NIComplexNumberPointerMatcher(_PointerMatcher):
 
     def __eq__(self, other):
         _PointerMatcher.__eq__(self, other)
-
-        for i in range(self.expected_size):
-            expected_value = self.expected_data[i]
-            actual_value = other[i]
-            if expected_value.real != actual_value.real or expected_value.imag != actual_value.imag:
-                return False
-        return True
+        return _compare_complex_number_arrays(self, other)
 
     def __repr__(self):
         return f"NIComplexNumberPointerMatcher({self.expected_data})"
@@ -311,13 +314,7 @@ class NIComplexNumberF32PointerMatcher(_PointerMatcher):
 
     def __eq__(self, other):
         _PointerMatcher.__eq__(self, other)
-
-        for i in range(self.expected_size):
-            expected_value = self.expected_data[i]
-            actual_value = other[i]
-            if expected_value.real != actual_value.real or expected_value.imag != actual_value.imag:
-                return False
-        return True
+        return _compare_complex_number_arrays(self, other)
 
     def __repr__(self):
         return f"NIComplexNumberF32PointerMatcher({self.expected_data})"
@@ -331,13 +328,7 @@ class NIComplexI16PointerMatcher(_PointerMatcher):
 
     def __eq__(self, other):
         _PointerMatcher.__eq__(self, other)
-
-        for i in range(self.expected_size):
-            expected_value = self.expected_data[i]
-            actual_value = other[i]
-            if expected_value.real != actual_value.real or expected_value.imag != actual_value.imag:
-                return False
-        return True
+        return _compare_complex_number_arrays(self, other)
 
     def __repr__(self):
         return f"NIComplexI16PointerMatcher({self.expected_data})"

build/unit_tests/test_codegen_helper.py

@@ -1217,7 +1217,7 @@ def test_get_ctype_variable_declaration_snippet_case_s220():
 
 def test_get_ctype_variable_declaration_snippet_case_b510():
     snippet = get_ctype_variable_declaration_snippet(parameters_for_testing[7], parameters_for_testing, IviDanceStep.NOT_APPLICABLE, config_for_testing, use_numpy_array=True)
-    assert snippet == ["output_ctype = _get_ctypes_pointer_for_buffer(value=output, library_type=numpy.ViInt64)  # case B510"]
+    assert snippet == ["output_ctype = _get_ctypes_pointer_for_buffer(value=output)  # case B510"]
 
 
 def test_get_ctype_variable_declaration_snippet_case_b540():

generated/nifake/nifake/unit_tests/_matchers.py

@@ -272,6 +272,15 @@ def __init__(self):
         _PointerMatcher.__init__(self, _visatype.ViReal64)
 
 
+def _compare_complex_number_arrays(expected, actual):
+    for i in range(expected.expected_size):
+        expected_value = expected.expected_data[i]
+        actual_value = actual[i]
+        if expected_value.real != actual_value.real or expected_value.imag != actual_value.imag:
+            return False
+    return True
+
+
 class NIComplexNumberPointerMatcher(_PointerMatcher):
     def __init__(self, expected_data, expected_size):
         _PointerMatcher.__init__(self, _complextype.NIComplexNumber)
@@ -280,13 +289,7 @@ def __init__(self, expected_data, expected_size):
 
     def __eq__(self, other):
         _PointerMatcher.__eq__(self, other)
-
-        for i in range(self.expected_size):
-            expected_value = self.expected_data[i]
-            actual_value = other[i]
-            if expected_value.real != actual_value.real or expected_value.imag != actual_value.imag:
-                return False
-        return True
+        return _compare_complex_number_arrays(self, other)
 
     def __repr__(self):
         return f"NIComplexNumberPointerMatcher({self.expected_data})"
@@ -300,13 +303,7 @@ def __init__(self, expected_data, expected_size):
 
     def __eq__(self, other):
         _PointerMatcher.__eq__(self, other)
-
-        for i in range(self.expected_size):
-            expected_value = self.expected_data[i]
-            actual_value = other[i]
-            if expected_value.real != actual_value.real or expected_value.imag != actual_value.imag:
-                return False
-        return True
+        return _compare_complex_number_arrays(self, other)
 
     def __repr__(self):
         return f"NIComplexNumberF32PointerMatcher({self.expected_data})"
@@ -320,13 +317,7 @@ def __init__(self, expected_data, expected_size):
 
     def __eq__(self, other):
         _PointerMatcher.__eq__(self, other)
-
-        for i in range(self.expected_size):
-            expected_value = self.expected_data[i]
-            actual_value = other[i]
-            if expected_value.real != actual_value.real or expected_value.imag != actual_value.imag:
-                return False
-        return True
+        return _compare_complex_number_arrays(self, other)
 
     def __repr__(self):
         return f"NIComplexI16PointerMatcher({self.expected_data})"