uptake latest proto file with optional value in GetValueResponse

Author: Mike Prosser

protos/ni/pythonpanel/v1/python_panel_service.proto

@@ -98,10 +98,7 @@ message GetValueRequest {
 
 message GetValueResponse {
   // The value
-  google.protobuf.Any value = 1;
-
-  // Was the value found?
-  bool found = 2;
+  optional google.protobuf.Any value = 1;
 }
 
 message SetValueRequest {

src/ni/pythonpanel/v1/python_panel_service_pb2.py

@@ -162,9 +162,6 @@ class GetValueResponse(google.protobuf.message.Message):
     DESCRIPTOR: google.protobuf.descriptor.Descriptor
 
     VALUE_FIELD_NUMBER: builtins.int
-    FOUND_FIELD_NUMBER: builtins.int
-    found: builtins.bool
-    """Was the value found?"""
     @property
     def value(self) -> google.protobuf.any_pb2.Any:
         """The value"""
@@ -173,10 +170,10 @@ class GetValueResponse(google.protobuf.message.Message):
         self,
         *,
         value: google.protobuf.any_pb2.Any | None = ...,
-        found: builtins.bool = ...,
     ) -> None: ...
-    def HasField(self, field_name: typing.Literal["value", b"value"]) -> builtins.bool: ...
-    def ClearField(self, field_name: typing.Literal["found", b"found", "value", b"value"]) -> None: ...
+    def HasField(self, field_name: typing.Literal["_value", b"_value", "value", b"value"]) -> builtins.bool: ...
+    def ClearField(self, field_name: typing.Literal["_value", b"_value", "value", b"value"]) -> None: ...
+    def WhichOneof(self, oneof_group: typing.Literal["_value", b"_value"]) -> typing.Literal["value"] | None: ...
 
 global___GetValueResponse = GetValueResponse
 

src/ni/pythonpanel/v1/python_panel_service_pb2.pyi

@@ -77,7 +77,6 @@ def GetValue(self, request, context):
         """Get a value for a control on the panel
         Status Codes for errors:
         - INVALID_ARGUMENT: The specified identifier contains invalid characters. Only alphanumeric characters and underscores are allowed.
-        - NOT_FOUND: The value with the specified identifier was not found
         """
         context.set_code(grpc.StatusCode.UNIMPLEMENTED)
         context.set_details('Method not implemented!')

src/ni/pythonpanel/v1/python_panel_service_pb2_grpc.py

@@ -55,7 +55,6 @@ class PythonPanelServiceStub:
     """Get a value for a control on the panel
     Status Codes for errors:
     - INVALID_ARGUMENT: The specified identifier contains invalid characters. Only alphanumeric characters and underscores are allowed.
-    - NOT_FOUND: The value with the specified identifier was not found
     """
 
     SetValue: grpc.UnaryUnaryMultiCallable[
@@ -104,7 +103,6 @@ class PythonPanelServiceAsyncStub:
     """Get a value for a control on the panel
     Status Codes for errors:
     - INVALID_ARGUMENT: The specified identifier contains invalid characters. Only alphanumeric characters and underscores are allowed.
-    - NOT_FOUND: The value with the specified identifier was not found
     """
 
     SetValue: grpc.aio.UnaryUnaryMultiCallable[
@@ -161,7 +159,6 @@ class PythonPanelServiceServicer(metaclass=abc.ABCMeta):
         """Get a value for a control on the panel
         Status Codes for errors:
         - INVALID_ARGUMENT: The specified identifier contains invalid characters. Only alphanumeric characters and underscores are allowed.
-        - NOT_FOUND: The value with the specified identifier was not found
         """
 
     @abc.abstractmethod

src/ni/pythonpanel/v1/python_panel_service_pb2_grpc.pyi

@@ -124,14 +124,15 @@ def get_value(self, panel_id: str, value_id: str) -> tuple[bool, object]:
             value_id: The ID of the control.
 
         Returns:
-            The value, and a boolean indicating if the value was found.
+            A tuple containing a boolean indicating whether the value was successfully retrieved and
+            the value itself (or None if not present).
         """
         get_value_request = GetValueRequest(panel_id=panel_id, value_id=value_id)
         response = self._invoke_with_retry(self._get_stub().GetValue, get_value_request)
-        if not response.found:
+        if response.HasField("value"):
+            return True, from_any(response.value)
+        else:
             return False, None
-        the_value = from_any(response.value)
-        return True, the_value
 
     def _get_stub(self) -> PythonPanelServiceStub:
         if self._stub is None:

src/nipanel/_panel_client.py

@@ -63,9 +63,9 @@ def EnumeratePanels(  # noqa: N802
     def GetValue(self, request: GetValueRequest, context: Any) -> GetValueResponse:  # noqa: N802
         """Trivial implementation for testing."""
         if request.value_id not in self._panel_value_ids.get(request.panel_id, {}):
-            return GetValueResponse(found=False)
+            return GetValueResponse()
         value = self._panel_value_ids[request.panel_id][request.value_id]
-        return GetValueResponse(found=True, value=value)
+        return GetValueResponse(value=value)
 
     def SetValue(self, request: SetValueRequest, context: Any) -> SetValueResponse:  # noqa: N802
         """Trivial implementation for testing."""