fix fake panel servicer to match real behavior better

Author: Mike Prosser

tests/unit/test_panel_client.py

@@ -19,18 +19,30 @@ def test___open_panels___enumerate_has_panels(fake_panel_channel: grpc.Channel)
     assert client.enumerate_panels() == ["panel1", "panel2"]
 
 
-def test___open_panels___close_panel_1___enumerate_has_panel_2(
+def test___open_panels___close_panel_1_with_reset___enumerate_has_panel_2(
     fake_panel_channel: grpc.Channel,
 ) -> None:
     client = create_panel_client(fake_panel_channel)
     client.open_panel("panel1", "uri1")
     client.open_panel("panel2", "uri2")
 
-    client.close_panel("panel1", reset=False)
+    client.close_panel("panel1", reset=True)
 
     assert client.enumerate_panels() == ["panel2"]
 
 
+def test___open_panels___close_panel_1_without_reset___enumerate_has_both_panels(
+    fake_panel_channel: grpc.Channel,
+) -> None:
+    client = create_panel_client(fake_panel_channel)
+    client.open_panel("panel1", "uri1")
+    client.open_panel("panel2", "uri2")
+
+    client.close_panel("panel1", reset=False)
+
+    assert client.enumerate_panels() == ["panel1", "panel2"]
+
+
 def test___get_unset_value_raises_exception(fake_panel_channel: grpc.Channel) -> None:
     client = create_panel_client(fake_panel_channel)
 

tests/utils/_fake_python_panel_servicer.py

@@ -37,8 +37,8 @@ def ClosePanel(  # noqa: N802
         self, request: ClosePanelRequest, context: Any
     ) -> ClosePanelResponse:
         """Trivial implementation for testing."""
-        self._panel_ids.remove(request.panel_id)
         if request.reset:
+            self._panel_ids.remove(request.panel_id)
             self._values.clear()
         return ClosePanelResponse()