brad's feedback

Author: Mike Prosser

examples/all_types/all_types_panel.py

@@ -6,7 +6,7 @@
 from define_types import all_types_with_values
 
 import nipanel
-import nipanel.controls as ni
+from nipanel.controls import enum_selectbox, flag_checkboxes
 
 
 st.set_page_config(page_title="All Types Example", page_icon="📊", layout="wide")
@@ -26,9 +26,9 @@
         if isinstance(default_value, bool):
             st.checkbox(label=name, value=default_value, key=name)
         elif isinstance(default_value, Flag):
-            ni.flag_checkboxes(panel, label=name, value=default_value, key=name)
+            flag_checkboxes(panel, label=name, value=default_value, key=name)
         elif isinstance(default_value, Enum) and not isinstance(default_value, Flag):
-            ni.enum_selectbox(panel, label=name, value=default_value, key=name)
+            enum_selectbox(panel, label=name, value=default_value, key=name)
         elif isinstance(default_value, int) and not isinstance(default_value, Flag):
             st.number_input(label=name, value=default_value, key=name)
         elif isinstance(default_value, float):

examples/nidaqmx/nidaqmx_continuous_analog_input_panel.py

@@ -11,7 +11,7 @@
 from streamlit_echarts import st_echarts
 
 import nipanel
-import nipanel.controls as ni
+from nipanel.controls import enum_selectbox
 
 
 st.set_page_config(page_title="NI-DAQmx Example", page_icon="📈", layout="wide")
@@ -76,7 +76,7 @@
                     key="voltage_max_value",
                 )
             with channel_right_column:
-                ni.enum_selectbox(
+                enum_selectbox(
                     panel,
                     label="Terminal Configuration",
                     value=TerminalConfiguration.DEFAULT,
@@ -104,22 +104,22 @@
                     key="thermocouple_max_value",
                 )
             with channel_middle_column:
-                ni.enum_selectbox(
+                enum_selectbox(
                     panel,
                     label="Units",
                     value=TemperatureUnits.DEG_C,
                     disabled=panel.get_value("is_running", False),
                     key="thermocouple_units",
                 )
-                ni.enum_selectbox(
+                enum_selectbox(
                     panel,
                     label="Thermocouple Type",
                     value=ThermocoupleType.K,
                     disabled=panel.get_value("is_running", False),
                     key="thermocouple_type",
                 )
             with channel_right_column:
-                ni.enum_selectbox(
+                enum_selectbox(
                     panel,
                     label="CJC Source",
                     value=CJCSource.CONSTANT_USER_VALUE,
@@ -219,7 +219,7 @@
         st.header("Logging Settings")
         logging_left_column, logging_right_column = st.columns(2)
         with logging_left_column:
-            ni.enum_selectbox(
+            enum_selectbox(
                 panel,
                 label="Logging Mode",
                 value=LoggingMode.OFF,

src/nipanel/_panel_value_accessor.py

@@ -3,7 +3,7 @@
 import collections
 import enum
 from abc import ABC
-from typing import TypeVar, overload, Any
+from typing import TypeVar, overload
 
 import grpc
 from ni_measurement_plugin_sdk_service.discovery import DiscoveryClient
@@ -46,7 +46,7 @@ def __init__(
         )
         self._panel_id = panel_id
         self._notify_on_set_value = notify_on_set_value
-        self._last_values: collections.defaultdict[str, Any] = collections.defaultdict(
+        self._last_values: collections.defaultdict[str, object] = collections.defaultdict(
             lambda: object()
         )