Skip to content

Add a section for a local workflow to CONTRIBUTING.md #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 9, 2025
Merged

Add a section for a local workflow to CONTRIBUTING.md #19

merged 7 commits into from
May 9, 2025

Conversation

@jfriedri-ni
Copy link
Collaborator

@jfriedri-ni jfriedri-ni commented May 7, 2025 •
edited
Loading

What does this Pull Request accomplish?

  • Add a section describing a local workflow to CONTRIBUTING.md

Why should this Pull Request be merged?

It addresses a TODO comment in the file

What testing has been done?

  • Run analyzers and tests
  • Build docs

@jfriedri-ni jfriedri-ni added the documentation Improvements or additions to documentation label May 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025 •
edited
Loading

Test Results

10 files  ±0  10 suites  ±0   8s ⏱️ +2s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
60 runs  ±0  60 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 80bc26f. ± Comparison against base commit e9622d7.

♻️ This comment has been updated with latest results.

@jfriedri-ni jfriedri-ni removed the request for review from mikeprosserni May 7, 2025 22:22
bkeryan
bkeryan approved these changes May 8, 2025
View reviewed changes
@bkeryan
Copy link
Collaborator

bkeryan commented May 8, 2025

This also reminded me, we don't have Sphinx set up in this repo yet. I added it in #21

bkeryan
bkeryan reviewed May 8, 2025
View reviewed changes
@jfriedri-ni jfriedri-ni merged commit 9502081 into main May 9, 2025
14 checks passed
@jfriedri-ni jfriedri-ni deleted the users/jfriedri/fix-typo branch May 9, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkeryan bkeryan bkeryan approved these changes

@csjall csjall csjall approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfriedri-ni @bkeryan @csjall