Skip to content

Conversation

@jfriedri-ni
Copy link
Collaborator

@jfriedri-ni jfriedri-ni commented May 29, 2025

What does this Pull Request accomplish?

This PR adds support for sequences of built-in types contained in

  • list
  • tuple
  • set
  • frozenset

Why should this Pull Request be merged?

We need to continue adding support for common data types.

What testing has been done?

Automated

New test test___sequence_of_builtin_type___set_value___gets_same_value with parameterized inputs.

By hand

image

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2025

Test Results

 10 files  ±  0   10 suites  ±0   11s ⏱️ +2s
 69 tests + 28   69 ✅ + 28  0 💤 ±0  0 ❌ ±0 
660 runs  +280  660 ✅ +280  0 💤 ±0  0 ❌ ±0 

Results for commit 526aca9. ± Comparison against base commit 75c1d63.

♻️ This comment has been updated with latest results.

@jfriedri-ni jfriedri-ni changed the title Users/jfriedri/lofi support for builtin sequences Add support for builtin sequences May 29, 2025
@jfriedri-ni
Copy link
Collaborator Author

jfriedri-ni commented May 29, 2025

Maybe I won't update the sample -- this seems too ornerous

> poetry add pandas-stubs --group lint

Using version ^2.2.3.250527 for pandas-stubs

Updating dependencies
Resolving dependencies... (0.0s)

The current project's supported Python range (>=3.9,<3.9.7 || >3.9.7,<4.0) is not compatible with some of the required packages Python requirement:
  - pandas-stubs requires Python >=3.10, so it will not be satisfied for Python >=3.9,<3.9.7 || >3.9.7,<3.10

Because no versions of pandas-stubs match >2.2.3.250527,<3.0.0.0
 and pandas-stubs (2.2.3.250527) requires Python >=3.10, pandas-stubs is forbidden.
So, because nipanel depends on pandas-stubs (^2.2.3.250527), version solving failed.

  • Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties

    For pandas-stubs, a possible solution would be to set the `python` property to ">=3.10,<4.0"

    https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies,
    https://python-poetry.org/docs/dependency-specification/#using-environment-markers

Signed-off-by: Joe Friedrichsen <[email protected]>
Signed-off-by: Joe Friedrichsen <[email protected]>
…upport-for-builtin-sequences

Signed-off-by: Joe Friedrichsen <[email protected]>
@jfriedri-ni jfriedri-ni merged commit f23d67c into main May 30, 2025
14 checks passed
@jfriedri-ni jfriedri-ni deleted the users/jfriedri/lofi-support-for-builtin-sequences branch June 2, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants