-
Couldn't load subscription status.
- Fork 0
Add support for builtin sequences #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jfriedri-ni
merged 10 commits into
main
from
users/jfriedri/lofi-support-for-builtin-sequences
May 30, 2025
Merged
Add support for builtin sequences #51
jfriedri-ni
merged 10 commits into
main
from
users/jfriedri/lofi-support-for-builtin-sequences
May 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Friedrichsen <[email protected]>
Signed-off-by: Joe Friedrichsen <[email protected]>
…upport-for-builtin-sequences
Signed-off-by: Joe Friedrichsen <[email protected]>
Signed-off-by: Joe Friedrichsen <[email protected]>
Signed-off-by: Joe Friedrichsen <[email protected]>
|
Maybe I won't update the sample -- this seems too ornerous
|
csjall
approved these changes
May 29, 2025
csjall
reviewed
May 29, 2025
mikeprosserni
approved these changes
May 30, 2025
Signed-off-by: Joe Friedrichsen <[email protected]>
Signed-off-by: Joe Friedrichsen <[email protected]>
Signed-off-by: Joe Friedrichsen <[email protected]>
…upport-for-builtin-sequences Signed-off-by: Joe Friedrichsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds support for sequences of built-in types contained in
Why should this Pull Request be merged?
We need to continue adding support for common data types.
What testing has been done?
Automated
New test
test___sequence_of_builtin_type___set_value___gets_same_valuewith parameterized inputs.By hand