Skip to content

Support non-default ports for the Discovery Service #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 18, 2025
Merged

Support non-default ports for the Discovery Service #116

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f21d54a
Resolve the discovery service and use it as the base URL for the refr…
jfriedri-ni Jul 16, 2025
760df05
Merge remote-tracking branch 'origin/main' into users/jfriedri/ab3191…
jfriedri-ni Jul 17, 2025
7af7a9b
Revert the reuse of the discovery client
jfriedri-ni Jul 17, 2025
88c7216
Resolve the proxy separately for refresh component
jfriedri-ni Jul 18, 2025
7e76582
Use __future__ to support py3.11 style type hints
jfriedri-ni Jul 18, 2025
0f41a19
Rework service resolution to use a global
jfriedri-ni Jul 18, 2025
058ca3f
Add thread safety and explicit lifetimes for system resources
jfriedri-ni Jul 18, 2025
0cdf51c
Use a single lock instance so access is exclusive
jfriedri-ni Jul 18, 2025
acb1a58
No need to use global for the lock
jfriedri-ni Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/nipanel/streamlit_refresh/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from streamlit.components.v1.custom_component import CustomComponent


_grpc_client_lock = threading.RLock()
_panel_service_proxy_location: str | None = None


Expand All @@ -26,7 +27,8 @@ def initialize_refresh_component(panel_id: str) -> CustomComponent:


def _get_or_resolve_proxy() -> str:
with threading.RLock():
global _grpc_client_lock
with _grpc_client_lock:
global _panel_service_proxy_location
if _panel_service_proxy_location is None:
with GrpcChannelPool() as grpc_channel_pool:
Expand Down