- 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
Add NI-SCOPE EX Binary Acquisition Example #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            DilmiWickramanayake
  merged 161 commits into
  main
from
users/DilmiWickramanayake/niscope_binary
  
      
      
   
  Aug 6, 2025 
      
    
                
     Merged
            
            Add NI-SCOPE EX Binary Acquisition Example #126
                    DilmiWickramanayake
  merged 161 commits into
  main
from
users/DilmiWickramanayake/niscope_binary
  
      
      
   
  Aug 6, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: Dilmi Wickramanayake <[email protected]>
Signed-off-by: Dilmi Wickramanayake <[email protected]>
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
…ttps://github.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_ex_fetch_forever
| Test Results   10 files  ± 0     10 suites  ±0   22s ⏱️ -9s Results for commit ce35c34. ± Comparison against base commit 5ade5a6. This pull request removes 26 and adds 29 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. | 
…thub.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_binary
…thub.com/ni/nipanel-python into users/DilmiWickramanayake/niscope_binary
              
                    mikeprosserni
  
              
              approved these changes
              
                  
                    Aug 4, 2025 
                  
              
              
            
            
        
          
                examples/niscope/niscope_binary_acquisition/niscope_binary_acquisition.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                examples/niscope/niscope_binary_acquisition/niscope_binary_acquisition_panel.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                examples/niscope/niscope_binary_acquisition/niscope_binary_acquisition_panel.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                examples/niscope/niscope_binary_acquisition/niscope_binary_acquisition_panel.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                examples/niscope/niscope_binary_acquisition/niscope_binary_acquisition_panel.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    hellovolcano
  
              
              requested changes
              
                  
                    Aug 4, 2025 
                  
              
              
            
            
        
          
                examples/niscope/niscope_binary_acquisition/niscope_binary_acquisition.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                examples/niscope/niscope_binary_acquisition/niscope_binary_acquisition_panel.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    csjall
  
              
              approved these changes
              
                  
                    Aug 6, 2025 
                  
              
              
            
            
              
                    hellovolcano
  
              
              approved these changes
              
                  
                    Aug 6, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What does this Pull Request accomplish?
Continuously acquires waveforms from NI-SCOPE, and displays data that is converted to binary
Why should this Pull Request be merged?
AB#3176534
What testing has been done?
Manual testing with simulated hardware Dev1
