Do not notify value changed when SetValue() is called from Streamlit script #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
If setting a value in a streamlit script sent the value update notification, the streamlit script would re-run, potentially setting the value again and causing an infinite loop. We need to prevent this by NOT notifying when StreamlitPanelValueAccessor.set_value() is called.
The SetValueRequest now includes a 'notify' flag. This flag is false when
StreamlitPanelValueAccessor.set_value()is called, and is true whenStreamlitPanel.set_value()is called.Why should this Pull Request be merged?
Implements AB#3145075
What testing has been done?
Validated with a debugger that setting a value using StreamlitPanel in a measurement script triggers the
_panelEventNotifier.NotifyPanelValueChanged(), but setting a value using StreamlitPanelValueAccessor in the streamlit script does not.test___panel___set_value___notifiestest___accessor___set_value___does_not_notify