-
Notifications
You must be signed in to change notification settings - Fork 0
Add scalar.proto, generate stubs, implement converter, and add unit tests. #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests. Signed-off-by: Michael Johansen <[email protected]>
mikeprosserni
approved these changes
Jun 10, 2025
jfriedri-ni
approved these changes
Jun 10, 2025
bkeryan
requested changes
Jun 10, 2025
… dependency. Signed-off-by: Michael Johansen <[email protected]>
Signed-off-by: Michael Johansen <[email protected]>
csjall
approved these changes
Jun 11, 2025
Signed-off-by: Michael Johansen <[email protected]>
bkeryan
approved these changes
Jun 11, 2025
Signed-off-by: Michael Johansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
The changes made in this PR will live in the nipanel package temporarily to allow for development and testing of gRPC conversion for Scalar with Units types. I will explain more about the long term location for these changes at the end of this section.
ScalarDatamessage from ASW into this python packageConverterthat converts scalar objects from python <--> protobuf.nitypespackage because it contains theScalarpython class.In the long term...
scalar.protofile will move into theni-apispackageni-apis-pythonrepo/packageni-apis-pythonrepo/packagenipanelonnitypescan be removedWhy should this Pull Request be merged?
Fulfills temporary development/testing defined by AB#3157159.
What testing has been done?
Unit tests pass.