Skip to content

Conversation

@mjohanse-emr
Copy link
Contributor

@mjohanse-emr mjohanse-emr commented Jun 9, 2025

What does this Pull Request accomplish?

The changes made in this PR will live in the nipanel package temporarily to allow for development and testing of gRPC conversion for Scalar with Units types. I will explain more about the long term location for these changes at the end of this section.

  • Copy the ScalarData message from ASW into this python package
  • Generate the grpc stubs for the new .proto file
  • Create a Converter that converts scalar objects from python <--> protobuf.
  • Write unit tests to exercise this converter class.
  • I had to add a dependency on the nitypes package because it contains the Scalar python class.

In the long term...

  • The scalar.proto file will move into the ni-apis package
  • The generated grpc stubs will move into the ni-apis-python repo/package
  • The conversion code will move into the ni-apis-python repo/package
  • The dependency from nipanel on nitypes can be removed

Why should this Pull Request be merged?

Fulfills temporary development/testing defined by AB#3157159.

What testing has been done?

Unit tests pass.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Test Results

 10 files  ±  0   10 suites  ±0   13s ⏱️ +3s
 78 tests + 11   78 ✅ + 11  0 💤 ±0  0 ❌ ±0 
750 runs  +110  750 ✅ +110  0 💤 ±0  0 ❌ ±0 

Results for commit 6eca4ac. ± Comparison against base commit 541273f.

♻️ This comment has been updated with latest results.

@mjohanse-emr mjohanse-emr marked this pull request as ready for review June 10, 2025 15:10
@mjohanse-emr mjohanse-emr requested a review from csjall as a code owner June 10, 2025 15:10
Michael Johansen added 2 commits June 11, 2025 09:20
@mjohanse-emr mjohanse-emr requested a review from bkeryan June 11, 2025 19:56
Signed-off-by: Michael Johansen <[email protected]>
@mjohanse-emr mjohanse-emr merged commit f05a081 into main Jun 11, 2025
14 checks passed
@mjohanse-emr mjohanse-emr deleted the users/mjohanse/scalar_conversion_code branch June 11, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants