Skip to content

Add type overloads for get_value() #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2025
Merged

Add type overloads for get_value() #78

merged 4 commits into from
Jun 17, 2025

Conversation

@mikeprosserni
Copy link
Collaborator

@mikeprosserni mikeprosserni commented Jun 16, 2025

What does this Pull Request accomplish?

If the user specifies a default value, then that value's type should be used for the return value of get_value().

Why should this Pull Request be merged?

feedback from #74

What testing has been done?

Existing autotests pass

@mikeprosserni mikeprosserni requested a review from bkeryan June 16, 2025 21:53
@mikeprosserni mikeprosserni marked this pull request as ready for review June 16, 2025 21:53
@mikeprosserni mikeprosserni requested a review from csjall as a code owner June 16, 2025 21:53
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025 •
edited
Loading

Test Results

 10 files  ± 0   10 suites  ±0   15s ⏱️ -1s
 85 tests + 5   85 ✅ + 5  0 💤 ±0  0 ❌ ±0 
820 runs  +50  820 ✅ +50  0 💤 ±0  0 ❌ ±0 

Results for commit cad8e5f. ± Comparison against base commit 5b3ea7e.

This pull request removes 2 and adds 7 tests. Note that renamed tests count towards both. 
tests.unit.test_streamlit_panel ‑ test___get_value_returns_default_when_value_not_set
tests.unit.test_streamlit_panel ‑ test___set_value___get_value_ignores_default

tests.unit.test_streamlit_panel ‑ test___no_set_value___get_value_returns_default
tests.unit.test_streamlit_panel ‑ test___panel___set_value___get_value_ignores_default
tests.unit.test_streamlit_panel ‑ test___set_bool_type___get_value_with_bool_default___returns_bool_type
tests.unit.test_streamlit_panel ‑ test___set_int_type___get_value_with_bool_default___raises_exception
tests.unit.test_streamlit_panel ‑ test___set_int_type___get_value_with_int_default___returns_int_type
tests.unit.test_streamlit_panel ‑ test___set_string_type___get_value_with_int_default___raises_exception
tests.unit.test_streamlit_panel ‑ test___set_string_type___get_value_with_string_default___returns_string_type

♻️ This comment has been updated with latest results.

bkeryan
bkeryan requested changes Jun 16, 2025
View reviewed changes
@mikeprosserni mikeprosserni requested a review from bkeryan June 17, 2025 14:34
bkeryan
bkeryan requested changes Jun 17, 2025
View reviewed changes
@mikeprosserni mikeprosserni requested a review from bkeryan June 17, 2025 18:16
@mikeprosserni mikeprosserni merged commit 25f796a into main Jun 17, 2025
14 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/better-default-values branch June 17, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkeryan bkeryan bkeryan approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikeprosserni @bkeryan