Add new protobuf converters to _convert.py. #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <[email protected]>
bkeryan
approved these changes
Jun 20, 2025
Signed-off-by: Michael Johansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds
DoubleAnalogWaveformConverterandScalarDataConverterto the list of converters supported by_convert.py'sto_any()andfrom_any()functions.I also addressed some feedback that Brad gave after my last PR was submitted.
#86 (comment)
Why should this Pull Request be merged?
These converters need to be included in
_convert.pyso that values read and written to the panel can use these converters.What testing has been done?
I added unit tests to check the
to_any()andfrom_any()codepaths for these converters. The tests are simple because more complex conversion tests are handled intest_protobuf_type_conversion.py.Unit tests, mypy, styleguide.