resolve PR comments

Author: Aravindhan Palanisamy

examples/assetmanagement/assets.py

@@ -43,7 +43,7 @@
             is_limited=False,
             date="2022-06-07T18:58:05.000Z",
         ),
-        is_n_i_asset=True,
+        is_NI_asset=True,
         workspace="846e294a-a007-47ac-9fc2-fac07eab240e",
         location=AssetLocation(
             state=AssetPresenceWithSystemConnection(
@@ -60,7 +60,7 @@
         ),
         properties={"Key1": "Value1"},
         keywords=["Keyword1"],
-        discovery_type=AssetDiscoveryType.AUTOMATIC,
+        discovery_type=AssetDiscoveryType.MANUAL,
         file_ids=["608a5684800e325b48837c2a"],
         supports_self_test=True,
         supports_reset=True,

nisystemlink/clients/assetmanagement/_asset_management_client.py

@@ -27,7 +27,7 @@ def __init__(self, configuration: Optional[HttpConfiguration] = None):
                 is used to obtain the configuration.
 
         Raises:
-            ApiException: If unable to communicate with the AssetManagement Service.
+            ApiException: If unable to communicate with the asset management Service.
         """
         if configuration is None:
             configuration = core.HttpConfigurationManager.get_configuration()
@@ -44,10 +44,10 @@ def create_assets(
             assets: Array of assets that should be created.
 
         Returns:
-            AssetsCreatePartialSuccessResponse: Array of created assets and array of failed.
+            CreateAssetsPartialSuccessResponse: Array of created assets and array of failed.
 
         Raises:
-            ApiException: If unable to communicate with the `asset management` service or if there are invalid
+            ApiException: If unable to communicate with the asset management service or if there are invalid
             arguments.
         """
         ...
@@ -62,11 +62,11 @@ def query_assets(
             query: Object containing filters to apply when retrieving assets.
 
         Returns:
-            AssetsResponse: Assets Response containing the assets satisfying the query and
+            QueryAssetsResponse: Assets Response containing the assets satisfying the query and
             the total count of matching assets.
 
         Raises:
-            ApiException: If unable to communicate with the `asset management` service or if there are invalid
+            ApiException: If unable to communicate with the asset management service or if there are invalid
             arguments.
         """
         ...
@@ -76,13 +76,12 @@ def delete_assets(self, ids: List[str]) -> models.DeleteAssetsResponse:
         """Delete Assets.
 
         Args:
-            assets: Arry of IDs of the assets to delete all information for.
+            ids: List of IDs of the assets to delete.
 
         Returns:
-            DeleteAssetsResponse: Response Object containing the ids of the assets which were deleted.
+            DeleteAssetsResponse: Response containing the IDs of the assets that were deleted.
 
         Raises:
-            ApiException: If unable to communicate with the `asset management` service or if there are invalid
-            arguments.
+            ApiException: If unable to communicate with the asset management service or if there are invalid arguments.
         """
         ...

nisystemlink/clients/assetmanagement/models/_asset.py

@@ -2,6 +2,7 @@
 from typing import Dict, List, Optional
 
 from nisystemlink.clients.core._uplink._json_model import JsonModel
+from pydantic import Field
 
 from ._asset_calibration import (
     CalibrationStatus,
@@ -67,7 +68,7 @@ class Asset(JsonModel):
     self_calibration: Optional[SelfCalibration] = None
     """Gets or sets the last self-calibration of the asset."""
 
-    is_NI_asset: Optional[bool] = None
+    is_NI_asset: Optional[bool] = Field(alias="isNIAsset", default=None)
     """Gets or sets whether this asset is an NI asset (true) or a third-party asset (false)."""
 
     id: Optional[str] = None

nisystemlink/clients/assetmanagement/models/_asset_location.py

@@ -20,14 +20,8 @@ class SystemConnection(Enum):
     [CONNECTED_UPDATE_PENDING, CONNECTED_UPDATE_SUCCESSFUL, CONNECTED_UPDATE_FAILED] are equivalent to CONNECTED.
     """
 
-    APPROVED = "APPROVED"
-    DISCONNECTED = "DISCONNECTED"
-    CONNECTED_UPDATE_PENDING = "CONNECTED_UPDATE_PENDING"
     CONNECTED = "CONNECTED"
-    CONNECTED_UPDATE_FAILED = "CONNECTED_UPDATE_FAILED"
-    UNSUPPORTED = "UNSUPPORTED"
-    ACTIVATED = "ACTIVATED"
-    CONNECTED_UPDATE_SUCCESSFUL = "CONNECTED_UPDATE_SUCCESSFUL"
+    DISCONNECTED = "DISCONNECTED"
 
 
 class AssetPresenceWithSystemConnection(JsonModel):

tests/integration/assetmanagement/test_asset_management.py

@@ -83,7 +83,7 @@ def create_asset(client: AssetManagementClient):
     def _create_assets(
         new_assets: CreateAssetRequest,
     ) -> CreateAssetsPartialSuccessResponse:
-        response = client.create_assets(new_assets)
+        response = client.create_assets(assets = new_assets)
         responses.append(response)
         return response