Skip to content

Commit 5983dfb

Browse files
author
Aravindhan Palanisamy
committed
resolved PR comments
1 parent a13b703 commit 5983dfb

File tree

4 files changed

+9
-12
lines changed

4 files changed

+9
-12
lines changed
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1-
from typing import Optional
2-
31
from nisystemlink.clients.core._uplink._json_model import JsonModel
42

53

64
class CreateVirtualSystemRequest(JsonModel):
75
"""Model for create virtual system response containing the minion ID of the system which is created."""
86

9-
alias: Optional[str] = None
7+
alias: str
108
"""Alias of the virtual system."""
119

12-
workspace: Optional[str] = None
10+
workspace: str
1311
"""Workspace to create the virtual system in."""
Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from typing import Optional
22

3-
from nisystemlink.clients.core._api_error import ApiError
43
from nisystemlink.clients.core._uplink._json_model import JsonModel
54

65

@@ -9,8 +8,3 @@ class CreateVirtualSystemResponse(JsonModel):
98

109
minionId: Optional[str] = None
1110
"""The minion ID of the created virtual system."""
12-
13-
error: Optional[ApiError] = None
14-
"""Represents if there is a error while creating
15-
virtual system.
16-
"""

nisystemlink/clients/systems/models/_remove_systems_request.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import List
1+
from typing import List, Optional
22

33
from nisystemlink.clients.core._uplink._json_model import JsonModel
44

@@ -8,3 +8,8 @@ class RemoveSystemsRequest(JsonModel):
88

99
tgt: List[str]
1010
"""Gets or sets array of strings representing the IDs of systems to remove from SystemLink."""
11+
12+
force: Optional[bool] = None
13+
"""Gets or sets a Boolean which specifies whether to remove systems from the database immediately (True)
14+
or wait until the unregister job returns from systems (False). If True, unregister job failures are not cached.
15+
"""

nisystemlink/clients/systems/models/_remove_systems_response.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ class RemoveSystemsResponse(JsonModel):
1717
"""The IDs of the systems that could not be removed."""
1818

1919
error: Optional[ApiError] = None
20-
"""Represents if there is a error while creating
20+
"""Represents if there is a error while removing
2121
virtual system.
2222
"""

0 commit comments

Comments
 (0)