Skip to content

Commit 8edf916

Browse files
committed
fix: update self review comments
1 parent cb30e6d commit 8edf916

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

examples/feeds/create_feed.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@
1414

1515
server_url = "" # SystemLink API URL
1616
server_api_key = "" # SystemLink API key
17-
workspace_id = "" # Systemlink workspace id
17+
workspace_id = (
18+
None # None uses Default workspace. Replace with Systemlink workspace id.
19+
)
20+
1821

1922
# Please provide the valid API key and API URL for client intialization.
2023
client = FeedsClient(HttpConfiguration(api_key=server_api_key, server_uri=server_url))

examples/feeds/delete_feed.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
None # None uses Default workspace. Replace with Systemlink workspace id.
1616
)
1717

18+
1819
# Please provide the valid API key and API URL for client intialization.
1920
client = FeedsClient(HttpConfiguration(api_key=server_api_key, server_uri=server_url))
2021

@@ -25,7 +26,7 @@
2526
feed_details = get_feed_by_name(feeds=query_feeds_response, name=FEED_NAME)
2627

2728
if feed_details and feed_details.id:
28-
created_feed_name = client.delete_feed(id=feed_details.id)
29+
client.delete_feed(id=feed_details.id)
2930
print("Feed deleted successfully.")
3031

3132
except ApiException as exp:

examples/feeds/query_and_upload_feeds.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
None # None uses Default workspace. Replace with Systemlink workspace id.
1919
)
2020

21+
2122
# Please provide the valid API key and API URL for client intialization.
2223
client = FeedsClient(HttpConfiguration(api_key=server_api_key, server_uri=server_url))
2324

@@ -28,7 +29,7 @@
2829
feed_details = get_feed_by_name(feeds=query_feeds_response, name=FEED_NAME)
2930

3031
if feed_details and feed_details.id:
31-
upload_package = client.upload_package(
32+
client.upload_package(
3233
feed_id=feed_details.id,
3334
overwrite=True,
3435
package_file_path=PACKAGE_PATH,

tests/integration/feeds/test_feeds_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def test__upload_package_content__succeeds(
205205
binary_pkg_file_data: BinaryIO,
206206
get_feed_name: Callable,
207207
):
208-
"""Test the case of upload package to feed."""
208+
"""Test the case of upload package content to feed."""
209209
create_feed_request_body = create_feed_request(
210210
feed_name=get_feed_name(),
211211
description=FEED_DESCRIPTION,

0 commit comments

Comments
 (0)