fix: Make condition type optional while querying specs (#123)

Author: vignesh261201

nisystemlink/clients/spec/models/_condition.py

@@ -30,7 +30,7 @@ class ConditionRange(JsonModel):
 class ConditionValueBase(JsonModel):
     """The base type for conditions that can be represented in several styles."""
 
-    condition_type: ConditionType
+    condition_type: Optional[ConditionType]
     """Type of the Condition."""
 
 

tests/integration/spec/test_spec.py

@@ -297,3 +297,35 @@ def test__query_spec_projection_columns__columns_returned(
         assert len(spec_columns) == 2
         assert "spec_id" in spec_columns
         assert "name" in spec_columns
+
+    def test__without_condition_type_projection__query_specs__condition_type_field_is_unset(
+        self, client: SpecClient, create_specs, create_specs_for_query, product
+    ):
+        request = QuerySpecificationsRequest(
+            product_ids=[product],
+            projection=[
+                SpecificationProjection.CONDITION_NAME,
+                SpecificationProjection.CONDITION_UNIT,
+            ],
+        )
+
+        response = client.query_specs(request)
+        specs = [vars(spec) for spec in response.specs or []]
+        condition_columns = ["name", "unit", "range", "discrete", "condition_type"]
+
+        spec_columns = {
+            f"condition_{column}"
+            for spec in specs
+            if "conditions" in spec
+            for condition in spec["conditions"]
+            for column in condition_columns
+            if getattr(condition.value if column != "name" else condition, column, None)
+            is not None
+        }
+
+        assert response.specs
+        assert len(response.specs) == 3
+        assert len(spec_columns) == 2
+        assert "condition_name" in spec_columns
+        assert "condition_unit" in spec_columns
+        assert "condition_type" not in spec_columns