refactor: Minor changes including change in function name

Author: IN2026-Rohith-Raja

examples/notification/notification.py

@@ -115,5 +115,5 @@ def create_notification_request_for_alarm(
     address_group=address_group,
     message_template=alarm_creation_template,
 )
-notification_client.apply_notification_strategy(request=notification_for_alarm_creation)
+notification_client.apply_dynamic_notification_strategy(request=notification_for_alarm_creation)
 print("Notification sent for alarm creation")

nisystemlink/clients/notification/_notification_client.py

@@ -32,7 +32,7 @@ def __init__(self, configuration: core.HttpConfiguration | None = None):
         super().__init__(configuration, base_path="/ninotification/v1/")
 
     @post("apply-dynamic-strategy")
-    def apply_notification_strategy(
+    def apply_dynamic_notification_strategy(
         self, request: models.DynamicStrategyRequest
     ) -> None:
         """Applies the notification strategy from the given request.

nisystemlink/clients/notification/models/_dynamic_notification_configuration.py

@@ -36,9 +36,9 @@ def validate_required_pairs(self) -> DynamicNotificationConfiguration:
         one of message_template_id or message_template is present.
         """
         if self.address_group_id is None and self.address_group is None:
-            raise ValidationError("AddressGroupId is required.")
+            raise ValidationError("One of either AddressGroupId or AddressGroup is required.")
 
         if self.message_template_id is None and self.message_template is None:
-            raise ValidationError("MessageTemplateId is required.")
+            raise ValidationError("One of either MessageTemplateId or MessageTemplate is required.")
 
         return self

nisystemlink/clients/notification/models/_smtp_address_group.py

@@ -22,7 +22,7 @@ class SmtpAddressFields(JsonModel):
 class SmtpAddressGroup(BaseNotificationMetadata):
     """Model defining notification recipients for SMTP service."""
 
-    interpreting_service_name: Literal["smtp"]
+    interpreting_service_name: Literal["smtp"] = "smtp"
     """Service name for SMTP-based interpretation."""
 
     fields: SmtpAddressFields

nisystemlink/clients/notification/models/_smtp_message_template.py

@@ -19,7 +19,7 @@ class SmtpMessageTemplateFields(JsonModel):
 class SmtpMessageTemplate(BaseNotificationMetadata):
     """Model defining message template for SMTP service"""
 
-    interpreting_service_name: Literal["smtp"]
+    interpreting_service_name: Literal["smtp"] = "smtp"
     """Service name for SMTP-based interpretation."""
 
     fields: SmtpMessageTemplateFields

tests/integration/notification/test_notification_client.py

@@ -94,7 +94,7 @@ class TestNotificationClient:
     def test__apply_strategy_with_correct_request__returns_none(
         self, client: NotificationClient, request_model: DynamicStrategyRequest
     ):
-        assert client.apply_notification_strategy(request=request_model) is None
+        assert client.apply_dynamic_notification_strategy(request=request_model) is None
 
     def test__apply_strategy_with_invalid_recipient__raises_exception(
         self,
@@ -119,7 +119,7 @@ def test__apply_strategy_with_invalid_recipient__raises_exception(
         )
 
         with pytest.raises(ApiException) as exc_info:
-            client.apply_notification_strategy(request=request_model)
+            client.apply_dynamic_notification_strategy(request=request_model)
 
         assert exc_info.value.http_status_code == 400
 
@@ -155,7 +155,7 @@ def test__apply_strategy_with_empty_subject_template_fields__raises_exception(
         )
 
         with pytest.raises(ApiException) as exc_info:
-            client.apply_notification_strategy(request=request_model)
+            client.apply_dynamic_notification_strategy(request=request_model)
 
         assert exc_info.value.http_status_code == 400
 
@@ -187,7 +187,7 @@ def test__apply_strategy_with_no_address_and_message_template_id__returns_none(
                 ]
             ),
         )
-        assert client.apply_notification_strategy(request=request_model) is None
+        assert client.apply_dynamic_notification_strategy(request=request_model) is None
 
     def test__apply_multiple_notification_configurations__returns_none(
         self,
@@ -226,4 +226,4 @@ def test__apply_multiple_notification_configurations__returns_none(
                 ]
             ),
         )
-        assert client.apply_notification_strategy(request=request_model) is None
+        assert client.apply_dynamic_notification_strategy(request=request_model) is None