Skip to content

Commit 6a9c10e

Browse files
authored
github: Specify permissions on the job level, not the workflow level (#68)
1 parent 51e950e commit 6a9c10e

File tree

3 files changed

+14
-17
lines changed

3 files changed

+14
-17
lines changed

.github/workflows/CI.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@ on:
88
workflow_call:
99
workflow_dispatch:
1010

11-
permissions:
12-
contents: read
13-
checks: write
14-
pull-requests: write
15-
1611
jobs:
1712
check_nitypes:
1813
name: Check nitypes
@@ -32,4 +27,8 @@ jobs:
3227
name: Report test results
3328
uses: ./.github/workflows/report_test_results.yml
3429
needs: [run_unit_tests, run_unit_tests_oldest_deps]
35-
if: always()
30+
if: always()
31+
permissions:
32+
contents: read
33+
checks: write
34+
pull-requests: write

.github/workflows/PR.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@ on:
88
workflow_call:
99
workflow_dispatch:
1010

11-
permissions:
12-
contents: read
13-
checks: write
14-
pull-requests: write
15-
1611
concurrency:
1712
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
1813
cancel-in-progress: true
@@ -21,3 +16,7 @@ jobs:
2116
run_ci:
2217
name: Run CI
2318
uses: ./.github/workflows/CI.yml
19+
permissions:
20+
contents: read
21+
checks: write
22+
pull-requests: write

.github/workflows/report_test_results.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,14 @@ on:
44
workflow_call:
55
workflow_dispatch:
66

7-
permissions:
8-
contents: read
9-
checks: write
10-
pull-requests: write
11-
127
jobs:
138
report_test_results:
149
name: Report test results
1510
runs-on: ubuntu-latest
11+
permissions:
12+
contents: read
13+
checks: write
14+
pull-requests: write
1615
steps:
1716
- name: Check out repo
1817
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -28,4 +27,4 @@ jobs:
2827
uses: EnricoMi/publish-unit-test-result-action@afb2984f4d89672b2f9d9c13ae23d53779671984 # v2.19.0
2928
with:
3029
files: "test_results/**/*.xml"
31-
if: always()
30+
if: always()

0 commit comments

Comments
 (0)