Skip to content

Commit 2187533

Browse files
committed
Minor PR feedback
1 parent 4dd9375 commit 2187533

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

.github/workflows/test_actions.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
matrix:
1313
os: [windows-latest, ubuntu-latest, macos-latest]
14-
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13, pypy3.10, pypy3.11]
14+
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13t, pypy3.10, pypy3.11]
1515
steps:
1616
- name: Check out repo
1717
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -45,7 +45,7 @@ jobs:
4545
strategy:
4646
matrix:
4747
os: [windows-latest, ubuntu-latest, macos-latest]
48-
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13, pypy3.10, pypy3.11]
48+
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13t, pypy3.10, pypy3.11]
4949
steps:
5050
- name: Check out repo
5151
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -72,7 +72,7 @@ jobs:
7272
strategy:
7373
matrix:
7474
os: [windows-latest, ubuntu-latest, macos-latest]
75-
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13, pypy3.10, pypy3.11]
75+
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13t, pypy3.10, pypy3.11]
7676
steps:
7777
- name: Check out repo
7878
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -104,7 +104,7 @@ jobs:
104104
strategy:
105105
matrix:
106106
os: [windows-latest, ubuntu-latest, macos-latest]
107-
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13, pypy3.10, pypy3.11]
107+
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13t, pypy3.10, pypy3.11]
108108
steps:
109109
- name: Check out repo
110110
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -216,10 +216,9 @@ jobs:
216216
name: Test analyze-project
217217
runs-on: ${{ matrix.os }}
218218
strategy:
219-
fail-fast: false
220219
matrix:
221220
os: [windows-latest, ubuntu-latest, macos-latest]
222-
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13, pypy3.10, pypy3.11]
221+
python-version: [3.9, '3.10', 3.11, 3.12, 3.13, 3.13t, pypy3.10, pypy3.11]
223222
steps:
224223
- name: Check out repo
225224
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -247,7 +246,8 @@ jobs:
247246
test_setup_poetry_cache_hit,
248247
test_setup_poetry_no_cache,
249248
test_check_project_version,
250-
test_update_project_version
249+
test_update_project_version,
250+
test_analyze_project,
251251
]
252252
if: ${{ !cancelled() }}
253253
steps:

analyze-project/README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
The `ni/python-actions/update-project-version` action analyzes the code quality
44
of a Python project using various linters and type checkers including
55
ni-python-styleguide, mypy (if the 'mypy' package is installed), and pyright
6-
(if the 'pyright' package is installed).uses Poetry to update the version of a Python
7-
project and creates a pull request to modify its `pyproject.toml` file. Publish workflows can use
8-
this to update the version in `pyproject.toml` for the next build.
6+
(if the 'pyright' package is installed).
97

108
This action requires Poetry, so you must call `ni/python-actions/setup-python` and
119
`ni/python-actions/setup-poetry` first.
@@ -27,7 +25,7 @@ You can specify `project-directory` to indicate the location of the pyproject.to
2725
file associated with the Python project you are analyzing.
2826

2927
```yaml
30-
- uses: ni/python-actions/update-project-version@v0.2
28+
- uses: ni/python-actions/update-project-version@v0
3129
with:
3230
project-directory: ${{ github.workspace }}/packages/myproject
3331
```
@@ -38,7 +36,7 @@ If there are extras you need to install from your pyproject.toml, specify a spac
3836
of extra groups to install. For example,
3937

4038
```yaml
41-
- uses: ni/python-actions/analyze-project@v0.2
39+
- uses: ni/python-actions/analyze-project@v0
4240
with:
4341
project-directory: ${{ github.workspace }}/packages/myproject
4442
extras: 'docs drivers'

analyze-project/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ inputs:
1919
runs:
2020
using: composite
2121
steps:
22-
- name: Get project name and version
22+
- name: Get project info
2323
id: get_project_info
2424
run: |
2525
result=$(poetry version)

0 commit comments

Comments
 (0)