Skip to content

Poetry cache key is not unique for pypy #10

@bkeryan

Description

@bkeryan

Bug Report

setup-poetry uses platform.python_version() to get the Python version to use in the cache key, but this does not distinguish between CPython and PyPy.

PS C:\dev\python-actions> python
Python 3.11.11 (0253c85bf5f8, Feb 26 2025, 10:43:25)
[PyPy 7.3.19 with MSC v.1941 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>>> import platform
>>>> platform.python_version()
'3.11.11'

Repro or Code Sample

ni/hightime#63 uses setup-poetry with pypy3.10 and pypy3.11.

Expected Behavior

The cache key is unique across Python versions.

Current Behavior

pypy3.10: key: hightime-Windows-pypypy7.3.19-c948617eededdca0b593f6f801a4f2af99b2349bf4dd5f2b6d76d20c3cfe67b9
pypy3.11: key: hightime-Windows-pypypy7.3.19-c948617eededdca0b593f6f801a4f2af99b2349bf4dd5f2b6d76d20c3cfe67b9

Possible Solution

Use sys.implementation.name and/or sys.implementation.version

Context

Updating hightime to use ni/python-actions

Your Environment

  • ni/python-actions version: v0.3.0
  • Python version: pypy3.10, pypy3.11

AB#3163510

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions