Skip to content

Update-project-version fails when a commit hash is used #46

@dixonjoel

Description

@dixonjoel

Bug Report

I ran update-project-version and it failed. We suspect it is because of using a commit hash and not a branch name.

Repro or Code Sample

I don't know why this failed for the couple of releases I did. I'm calling the update-project-action here.

Expected Behavior

Create a PR in the repo for bumping the project version.

Current Behavior

Failure. Here's some log info. See this run.

  [0d9ef0bb-fabf-4858-99fb-2e3fcf7e0035 5b906c0] [319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0] chore: Update project ni.measurements.metadata.v1.proto to v0.1.0.dev4
   Author: dixonjoel <[email protected]>
   1 file changed, 1 insertion(+), 1 deletion(-)
  /usr/bin/git stash push --include-untracked
  No local changes to save
  /usr/bin/git rev-list --right-only --count 319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0...0d9ef0bb-fabf-4858-99fb-2e3fcf7e0035
  1
  /usr/bin/git -c protocol.version=2 fetch --no-tags --progress --no-recurse-submodules --force --depth=11 origin users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0:refs/remotes/origin/users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0
  fatal: couldn't find remote ref users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0
  Pull request branch 'users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0' does not exist yet.
  /usr/bin/git checkout --progress -B users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0 0d9ef0bb-fabf-4858-99fb-2e3fcf7e0035 --

Possible Solution

@bkeryan suggests this:

I think it could use
git branch -a --contains
to find potential branches
it probably ought to try main first

Context

Your Environment

  • ni/python-actions version
  • Python version

AB#3455360

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions