Skip to content

Commit 3a19818

Browse files
authored
Change pr commenter tooling (#89)
* add org-check to PR notify * setup new style comment on PR * push new change * update actual comment job as well * Everybody gets a comment * Update .github/workflows/Notify-Convention-Change.yml
1 parent 478eebd commit 3a19818

File tree

3 files changed

+52
-24
lines changed

3 files changed

+52
-24
lines changed
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
on:
2+
pull_request_target:
3+
paths:
4+
- '*'
5+
- '!docs/Coding-Conventions.md'
6+
7+
jobs:
8+
comment_on_pr:
9+
runs-on: ubuntu-latest
10+
name: PR comment
11+
steps:
12+
- name: Checkout
13+
uses: actions/checkout@v3
14+
15+
- name: Comment on PR
16+
uses: thollander/actions-comment-pull-request@v1
17+
with:
18+
message: |
19+
Thank you for contributing! :wave:
20+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/Notify-Convention-Change.md

Lines changed: 0 additions & 19 deletions
This file was deleted.

.github/workflows/Notify-Convention-Change.yml

Lines changed: 32 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,39 @@ on:
66
- docs/Coding-Conventions.md
77

88
jobs:
9+
org-check:
10+
name: Check GitHub Organization
11+
if: github.repository_owner == 'ni'
12+
runs-on: ubuntu-20.04
13+
steps:
14+
- name: Noop
15+
run: "true"
916
notify:
1017
runs-on: ubuntu-latest
18+
needs: org-check
1119
steps:
12-
- uses: actions/checkout@master
13-
- uses: harupy/comment-on-pr@master
14-
env:
15-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
20+
- uses: actions/checkout@main
21+
- name: Comment on PR
22+
uses: thollander/actions-comment-pull-request@v1
1623
with:
17-
filename: Notify-Convention-Change.md
24+
message: |
25+
Thank you for contributing! :wave:
26+
27+
Since this changes the Coding Conventions, I'll @-mention the appropriate NI engineers.
28+
@alejandro5042
29+
@alexweav
30+
@DavidCurtiss
31+
@irwand
32+
@jryckman
33+
@kcuzner
34+
@mshafer-NI
35+
@neilvana
36+
@nethrasuresh
37+
@pakdev
38+
@rtzoeller
39+
@sbethur
40+
@stick152
41+
@Adithyak1998
42+
@innagarc
43+
@ShibaniRout
44+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)