Addressing PR comments: added locator to queryReturnTypeDropdown

BlankaOnodi · BlankaOnodi · commit dfc888cce843 · 2026-04-03T18:24:52.000+03:00
diff --git a/acceptance-tests/page-objects/dashboard/components/dashboard-variable/dashboard-asset-variable.component.ts b/acceptance-tests/page-objects/dashboard/components/dashboard-variable/dashboard-asset-variable.component.ts
@@ -1,12 +1,12 @@
-import { Page } from "playwright/test";
+import { Locator, Page } from "playwright/test";
 import { DashboardVariableBaseComponent } from "./dashboard-variable-base.component";
 
 export class DashboardAssetVariableComponent extends DashboardVariableBaseComponent {
     constructor(page: Page) {
         super(page);
     }
 
-    public queryReturnTypeDropdown(dropdownOptionName: string) {
+    public queryReturnTypeDropdown(dropdownOptionName: string): Locator {
         return this.page.locator('div').filter({ hasText: new RegExp(`^${dropdownOptionName}$`) }).nth(2);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,12 @@`
`1`		`-import { Page } from "playwright/test";`
	`1`	`+import { Locator, Page } from "playwright/test";`
`2`	`2`	`import { DashboardVariableBaseComponent } from "./dashboard-variable-base.component";`
`3`	`3`
`4`	`4`	`export class DashboardAssetVariableComponent extends DashboardVariableBaseComponent {`
`5`	`5`	`constructor(page: Page) {`
`6`	`6`	`super(page);`
`7`	`7`	`}`
`8`	`8`
`9`		`- public queryReturnTypeDropdown(dropdownOptionName: string) {`
	`9`	`+ public queryReturnTypeDropdown(dropdownOptionName: string): Locator {`
`10`	`10`	return this.page.locator('div').filter({ hasText: new RegExp(`^${dropdownOptionName}$`) }).nth(2);
`11`	`11`	`}`
`12`	`12`