Skip to content

Commit 6610571

Browse files
committed
Breaking dangerous superuser burn into mock and test mocks.
1 parent e3d101d commit 6610571

File tree

4 files changed

+24
-28
lines changed

4 files changed

+24
-28
lines changed

README.md

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -114,19 +114,6 @@ contract MyArtSale is
114114
super._setTokenUri(_tokenId, _uri);
115115
}
116116
117-
/**
118-
* @dev Removes a NFT from owner.
119-
* @param _tokenId Which NFT we want to remove.
120-
*/
121-
function burn(
122-
uint256 _tokenId
123-
)
124-
external
125-
onlyOwner
126-
{
127-
super._burn(_tokenId);
128-
}
129-
130117
}
131118
```
132119

src/contracts/mocks/nf-token-mock.sol

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,4 @@ contract NFTokenMock is
2626
super._mint(_to, _tokenId);
2727
}
2828

29-
/**
30-
* @dev Removes a NFT from owner.
31-
* @param _tokenId Which NFT we want to remove.
32-
*/
33-
function burn(
34-
uint256 _tokenId
35-
)
36-
external
37-
onlyOwner
38-
{
39-
super._burn(_tokenId);
40-
}
41-
4229
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
pragma solidity 0.5.2;
2+
3+
import "../../contracts/mocks/nf-token-mock.sol";
4+
5+
contract NFTokenTestMock is
6+
NFTokenMock
7+
{
8+
9+
/**
10+
* @dev Removes a NFT from owner.
11+
* @param _tokenId Which NFT we want to remove.
12+
*/
13+
function burn(
14+
uint256 _tokenId
15+
)
16+
external
17+
onlyOwner
18+
{
19+
super._burn(_tokenId);
20+
}
21+
22+
}

src/tests/tokens/nf-token.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ spec.beforeEach(async (ctx) => {
3939

4040
spec.beforeEach(async (ctx) => {
4141
const nfToken = await ctx.deploy({
42-
src: './build/nf-token-mock.json',
43-
contract: 'NFTokenMock',
42+
src: './build/nf-token-test-mock.json',
43+
contract: 'NFTokenTestMock',
4444
});
4545
ctx.set('nfToken', nfToken);
4646
});

0 commit comments

Comments
 (0)