Merge pull request #241 from 0xcert/test-extcodehash

WIP: test code hash

Author: xpepermint

src/tests/mocks/nf-token-receiver-test-mock.sol

@@ -6,6 +6,7 @@ import "../../contracts/tokens/erc721-token-receiver.sol";
 contract NFTokenReceiverTestMock is
   ERC721TokenReceiver
 {
+  event Received();
 
   function onERC721Received(
     address _operator,
@@ -14,14 +15,14 @@ contract NFTokenReceiverTestMock is
     bytes calldata _data
   )
     external
-    pure
     override
     returns(bytes4)
   {
     _operator;
     _from;
     _tokenId;
     _data;
+    emit Received();
     return 0x150b7a02;
   }
 

src/tests/mocks/sends-to-self-on-construct.sol

@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.6;
+
+import "../../contracts/mocks/nf-token-mock.sol";
+import "./nf-token-receiver-test-mock.sol";
+
+contract SendsToSelfOnConstruct is
+  NFTokenReceiverTestMock
+{
+  uint constant TOKEN_ID = 1;
+
+  constructor()
+  {
+    NFTokenMock tokens = new NFTokenMock();
+    tokens.mint(address(this), TOKEN_ID);
+    tokens.safeTransferFrom(address(this), address(this), TOKEN_ID);
+  }
+
+}

src/tests/tokens/nf-token.test.ts

@@ -397,4 +397,17 @@ spec.test('throws when trying to burn non existant NFT', async (ctx) => {
   const id1 = ctx.get('id1');
 
   await ctx.reverts(() => nftoken.instance.methods.burn(id1).send({ from: owner }), '003002');
-});
+});
+
+spec.test('safeTransfer does not call onERC721Received to constructing contract', async (ctx) => {
+  const sendsToSelfOnConstruct = await ctx.deploy({ 
+    src: './build/sends-to-self-on-construct.json',
+    contract: 'SendsToSelfOnConstruct',
+  });
+
+  const logs = sendsToSelfOnConstruct.receipt.logs;
+  ctx.is(logs.length, 2); // There need to be 2 logs. First transfer event for creating the token. Second transfer event for sending yourself a token.
+  // There must not be a Receive event.
+  ctx.is(logs[0].topics[0], '0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef'); // this represents transfer topic hash
+  ctx.is(logs[1].topics[0], '0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef'); // this represents transfer topic hash
+});