Added TODOs related to interface TransportIndicesResolvingAction

Author: lukasz-soszynski-eliatra

.idea/runConfigurations/Debug_OpenSearch.xml

@@ -64,6 +64,7 @@ public final class CountRequest extends ActionRequest implements IndicesRequest.
     private Float minScore;
 
     public CountRequest() {}
+    // TODO: do we need implementation of TransportIndicesResolvingAction
 
     /**
      * Constructs a new count request against the indices. No indices provided here means that count will execute on all indices.

client/rest-high-level/src/main/java/org/opensearch/client/core/CountRequest.java

@@ -58,7 +58,8 @@
 import java.util.Collections;
 
 public class TransportSearchTemplateAction extends HandledTransportAction<SearchTemplateRequest, SearchTemplateResponse> {
-
+    // TODO: can we reuse implementation in TransportIndicesResolvingAction from TransportSearchAction?
+    // TransportIndicesResolvingAction implement the interface
     private static final String TEMPLATE_LANG = MustacheScriptEngine.NAME;
 
     protected final ScriptService scriptService;

modules/lang-mustache/src/main/java/org/opensearch/script/mustache/TransportSearchTemplateAction.java

@@ -80,6 +80,10 @@
  * averaged precision at n.
  */
 public class TransportRankEvalAction extends HandledTransportAction<RankEvalRequest, RankEvalResponse> {
+    // TODO: implementation of TransportIndicesResolvingAction, can we reuse implementation from TransportSearchAction (MultiSearch used)?
+    // MultiSearch used under the hood. Probably each search request has the same indices and index options
+    // Should we reuse TransportSearchAction?
+
     private final Client client;
     private final ScriptService scriptService;
     private final NamedXContentRegistry namedXContentRegistry;

modules/rank-eval/src/main/java/org/opensearch/index/rankeval/TransportRankEvalAction.java

@@ -55,6 +55,7 @@
  * @opensearch.internal
  */
 public final class TransportCloneSnapshotAction extends TransportClusterManagerNodeAction<CloneSnapshotRequest, AcknowledgedResponse> {
+    // TODO: Q do we need here extensions related to TransportIndicesResolvingAction
 
     private final SnapshotsService snapshotsService;
 

server/src/main/java/org/opensearch/action/admin/cluster/snapshots/clone/TransportCloneSnapshotAction.java

@@ -102,6 +102,8 @@ private DeleteDataStreamAction() {
      */
     @PublicApi(since = "1.0.0")
     public static class Request extends ClusterManagerNodeRequest<Request> implements IndicesRequest.Replaceable {
+        // TODO: How we should implement the interface TransportIndicesResolvingAction
+        // - should we return just the data stream names or the backing indices?
 
         private String[] names;
 

server/src/main/java/org/opensearch/action/admin/indices/datastream/DeleteDataStreamAction.java

@@ -56,6 +56,8 @@
  * @opensearch.internal
  */
 public class TransportAutoPutMappingAction extends TransportClusterManagerNodeAction<PutMappingRequest, AcknowledgedResponse> {
+    // TODO: Q do we need here extensions related to TransportIndicesResolvingAction
+    // implementation may relay on TransportPutMappingAction
 
     private final MetadataMappingService metadataMappingService;
 
@@ -102,7 +104,7 @@ protected void doExecute(Task task, PutMappingRequest request, ActionListener<Ac
 
     @Override
     protected ClusterBlockException checkBlock(PutMappingRequest request, ClusterState state) {
-        String[] indices = new String[] { request.getConcreteIndex().getName() };
+        String[] indices = new String[] { request.getConcreteIndex().getName() }; // todo this should be a result of resolveIndices method
         return state.blocks().indicesBlockedException(ClusterBlockLevel.METADATA_WRITE, indices);
     }
 

server/src/main/java/org/opensearch/action/admin/indices/mapping/put/TransportAutoPutMappingAction.java

@@ -498,6 +498,11 @@ public int hashCode() {
      * @opensearch.internal
      */
     public static class TransportAction extends HandledTransportAction<Request, Response> {
+        // TODO: TransportIndicesResolvingAction
+        // to implement the interface we need to first execute the action or return index all
+        // how we should treat data stream here.
+        // check how security plugin handles this
+        // try to execute the action in the resolveIndices method
 
         private final ThreadPool threadPool;
         private final ClusterService clusterService;

server/src/main/java/org/opensearch/action/admin/indices/resolve/ResolveIndexAction.java

@@ -44,6 +44,8 @@
 public class TransportHotToWarmTieringAction extends TransportClusterManagerNodeAction<TieringIndexRequest, HotToWarmTieringResponse> implements
     TransportIndicesResolvingAction<TieringIndexRequest> {
 
+    // TODO: implementation of TransportIndicesResolvingAction should be simple here
+
     private static final Logger logger = LogManager.getLogger(TransportHotToWarmTieringAction.class);
     private final ClusterInfoService clusterInfoService;
     private final DiskThresholdSettings diskThresholdSettings;

server/src/main/java/org/opensearch/action/admin/indices/tiering/TransportHotToWarmTieringAction.java

@@ -46,6 +46,8 @@ private SearchViewAction() {
      */
     @ExperimentalApi
     public static class Request extends SearchRequest {
+        // TODO: How we should handle the interface TransportIndicesResolvingAction here?]
+        // ignore if this does not work with non admnin user
 
         private final String view;