Skip to content

Commit 62c156b

Browse files
Jonathan Bellpopcornmix
authored andcommitted
net: genet: enable link energy detect powerdown for external PHYs
There are several warts surrounding bcmgenet_mii_probe() as this function is called from ndo_open, but it's calling registration-type functions. The probe should be called at probe time and refactored such that the PHY device data can be extracted to limit the scope of this flag to Broadcom PHYs. For now, pass this flag in as it puts our attached PHY into a low-power state when disconnected. Signed-off-by: Jonathan Bell <[email protected]>
1 parent ab2b633 commit 62c156b

File tree

1 file changed

+2
-0
lines changed
  • drivers/net/ethernet/broadcom/genet

1 file changed

+2
-0
lines changed

drivers/net/ethernet/broadcom/genet/bcmmii.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,8 @@ int bcmgenet_mii_probe(struct net_device *dev)
317317
/* Communicate the integrated PHY revision */
318318
if (priv->internal_phy)
319319
phy_flags = priv->gphy_rev;
320+
else
321+
phy_flags = PHY_BRCM_AUTO_PWRDWN_ENABLE;
320322

321323
/* This is an ugly quirk but we have not been correctly interpreting
322324
* the phy_interface values and we have done that across different

0 commit comments

Comments
 (0)