Skip to content

Commit 908806a

Browse files
aiamadeusgregkh
authored andcommitted
phy: rockchip: naneng-combphy: fix phy reset
commit fbcbffb upstream. Currently, the USB port via combophy on the RK3528/RK3588 SoC is broken. usb usb8-port1: Cannot enable. Maybe the USB cable is bad? This is due to the combphy of RK3528/RK3588 SoC has multiple resets, but only "phy resets" need assert and deassert, "apb resets" don't need. So change the driver to only match the phy resets, which is also what the vendor kernel does. Fixes: 7160820 ("phy: rockchip: add naneng combo phy for RK3568") Cc: FUKAUMI Naoki <[email protected]> Cc: Michael Zimmermann <[email protected]> Signed-off-by: Chukun Pan <[email protected]> Reviewed-by: Heiko Stuebner <[email protected]> Tested-by: FUKAUMI Naoki <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 9617387 commit 908806a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/phy/rockchip/phy-rockchip-naneng-combphy.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ static int rockchip_combphy_parse_dt(struct device *dev, struct rockchip_combphy
309309

310310
priv->ext_refclk = device_property_present(dev, "rockchip,ext-refclk");
311311

312-
priv->phy_rst = devm_reset_control_array_get_exclusive(dev);
312+
priv->phy_rst = devm_reset_control_get(dev, "phy");
313313
if (IS_ERR(priv->phy_rst))
314314
return dev_err_probe(dev, PTR_ERR(priv->phy_rst), "failed to get phy reset\n");
315315

0 commit comments

Comments
 (0)