Skip to content

Commit a87a21a

Browse files
Chenghai Huanggregkh
authored andcommitted
crypto: hisilicon/qm - set NULL to qm->debug.qm_diff_regs
[ Upstream commit f0cafb0 ] When the initialization of qm->debug.acc_diff_reg fails, the probe process does not exit. However, after qm->debug.qm_diff_regs is freed, it is not set to NULL. This can lead to a double free when the remove process attempts to free it again. Therefore, qm->debug.qm_diff_regs should be set to NULL after it is freed. Fixes: 8be0913 ("crypto: hisilicon/debugfs - Fix debugfs uninit process issue") Signed-off-by: Chenghai Huang <[email protected]> Signed-off-by: Herbert Xu <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 81b43dd commit a87a21a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/crypto/hisilicon/debugfs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -888,6 +888,7 @@ static int qm_diff_regs_init(struct hisi_qm *qm,
888888
dfx_regs_uninit(qm, qm->debug.qm_diff_regs, ARRAY_SIZE(qm_diff_regs));
889889
ret = PTR_ERR(qm->debug.acc_diff_regs);
890890
qm->debug.acc_diff_regs = NULL;
891+
qm->debug.qm_diff_regs = NULL;
891892
return ret;
892893
}
893894

0 commit comments

Comments
 (0)