Skip to content

Commit e8dbcff

Browse files
committed
Revert type annotations to allow installations for Python<3.9
1 parent 184768b commit e8dbcff

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

pybm/commands/run.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def run(self, args: List[str]) -> int:
133133
runner: BenchmarkRunner = get_runner_class(config=self.config)
134134

135135
verbose: bool = options.verbose
136-
env_ids: list[str] = options.environments or []
136+
env_ids: List[str] = options.environments or []
137137
run_all: bool = options.run_all
138138
checkout_mode: bool = options.checkout
139139
source_ref: Optional[str] = options.benchmark_source

pybm/util/extras.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ def get_extras():
22
"""Extra pybm functionality, specified as a valid argument to
33
setuptools.setup's 'extras_require' keyword argument."""
44
extra_features = {"gbm": ["git+https://github.com/google/benchmark"]}
5-
extra_features["all"] = sum(extra_features.values(), start=[])
5+
extra_features["all"] = sum(extra_features.values(), [])
66
return extra_features

setup.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1+
from typing import List
2+
13
from setuptools import setup, find_packages
24

35

4-
def get_requirements() -> list[str]:
6+
def get_requirements() -> List[str]:
57
with open("requirements.txt", "r") as f:
68
return f.readlines()
79

@@ -12,7 +14,7 @@ def get_extras():
1214
extra_features = {
1315
"gbm": ["google_benchmark @ git+https://github.com/google/benchmark"]
1416
}
15-
extra_features["all"] = sum(extra_features.values(), start=[])
17+
extra_features["all"] = sum(extra_features.values(), [])
1618
return extra_features
1719

1820

0 commit comments

Comments
 (0)