Skip to content

Commit 7064f6b

Browse files
hunshcnaignas
andauthored
fix(gazelle): make gazelle_python_manifest.genrule manual (bazel-contrib#2097)
Fix bazel-contrib#2096 --------- Co-authored-by: Ignas Anikevicius <[email protected]>
1 parent dbc6c04 commit 7064f6b

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

CHANGELOG.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ A brief description of the categories of changes:
2929
when the wheel is downloaded using `download_only` feature to aid debugging.
3030
* (gazelle): Simplify and make gazelle_python.yaml have only top level package name.
3131
It would work well in cases to reduce merge conflicts.
32+
* (toolchains): Change some old toochain versions to use [20240726] release to
33+
include dependency updates `3.8.19`, `3.9.19`, `3.10.14`, `3.11.9`
34+
* (toolchains): Bump default toolchain versions to:
35+
* `3.12 -> 3.12.4`
3236

3337
### Fixed
3438
* (rules) Signals are properly received when using {obj}`--bootstrap_impl=script`
@@ -49,10 +53,8 @@ A brief description of the categories of changes:
4953
* (pip) Correctly use the `sdist` downloaded by the bazel downloader when using
5054
`experimental_index_url` feature. Fixes
5155
[#2091](https://github.com/bazelbuild/rules_python/issues/2090).
52-
* (toolchains): Change some old toochain versions to use [20240726] release to
53-
include dependency updates `3.8.19`, `3.9.19`, `3.10.14`, `3.11.9`
54-
* (toolchains): Bump default toolchain versions to:
55-
* `3.12 -> 3.12.4`
56+
* (gazelle) Make `gazelle_python_manifest.update` manual to avoid unnecessary
57+
network behavior.
5658

5759
### Added
5860
* (rules) `PYTHONSAFEPATH` is inherited from the calling environment to allow

gazelle/manifest/defs.bzl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ def gazelle_python_manifest(
9595
modules_mapping,
9696
manifest_generator_hash,
9797
] + ([requirements] if requirements else []),
98+
tags = ["manual"],
9899
)
99100

100101
py_binary(
@@ -109,7 +110,8 @@ def gazelle_python_manifest(
109110
generated_manifest,
110111
manifest,
111112
],
112-
**kwargs
113+
tags = kwargs.get("tags", []) + ["manual"],
114+
**{k: v for k, v in kwargs.items() if k != "tags"}
113115
)
114116

115117
if requirements:

0 commit comments

Comments
 (0)