dateColumn: Allow rowData to be a (parseable) string #148
ajboni
started this conversation in
Feature requests
Replies: 2 comments 1 reply
-
Hey @ajboni , As it is a fairly simple column, feel free to suggest a pull request to enhance it, can can move forward from there ;) |
Beta Was this translation helpful? Give feedback.
1 reply
-
Hey @ajboni , |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
https://github.com/Equify/react-datasheet-grid/blob/4a4c955bf3d46adb7dc75577e62d3ed880705e01/src/columns/dateColumn.tsx#L30-L32
Coming from a serialized json dataset where the data for the date column is a string this will throw an error trying to convert to isoString.
To avoid the burden of manually creating a date object for every row on initialization, maybe datecolumn could tryParse for a datetime string.
Or maybe, just directly use strings?
Beta Was this translation helpful? Give feedback.
All reactions