Skip to content

Conversation

@calda
Copy link
Collaborator

@calda calda commented Sep 22, 2025

This PR updates the trailingCommas rule to handle a Swift 6.2 bug where trailing commas are unexpectedly not allowed in closure literal tuple return types.

This example does not compile in Swift 6.2:

let closure = { () -> (
  foo: String,
  bar: String,
) in
  (foo: "foo", bar: "bar")
}

I confirmed this fix also fixes this issue, so this should be supported in Swift 6.3: swiftlang/swift#84421

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.39%. Comparing base (6afe143) to head (a753155).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2213      +/-   ##
===========================================
+ Coverage    95.37%   95.39%   +0.01%     
===========================================
  Files          155      155              
  Lines        30033    30042       +9     
===========================================
+ Hits         28644    28658      +14     
+ Misses        1389     1384       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@calda calda merged commit 9b8324b into nicklockwood:develop Sep 22, 2025
11 checks passed
calda added a commit that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant