Skip to content

Commit 752bdf7

Browse files
Copilotstmatengss
authored andcommitted
[Store] Fix compilation warnings for missing field initializers (kvcache-ai#1232)
* Initial plan * Fix compilation warnings for visibility and missing initializers Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com> * Complete fix for compilation warnings Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com> * Remove build artifacts and update .gitignore Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com> * Use pragma GCC diagnostic to suppress visibility warnings instead of attributes Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com> * Narrow scope of pragma diagnostic directives for lambda Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com> * fix * Revert all changes in mooncake-transfer-engine directory Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com> Co-authored-by: Teng Ma <sima.mt@alibaba-inc.com>
1 parent 3e2ec7b commit 752bdf7

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,3 +198,6 @@ mooncake-wheel/mooncake/transfer_engine_bench
198198

199199
# Claude Code Memory
200200
CLAUDE.md
201+
202+
# CodeQL
203+
_codeql_detected_source_root

mooncake-store/src/storage_backend.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,7 +1032,7 @@ tl::expected<int64_t, ErrorCode> StorageBackendAdaptor::BatchOffload(
10321032

10331033
metadatas.emplace_back(
10341034
StorageObjectMetadata{-1, 0, static_cast<int64_t>(kv.key.size()),
1035-
static_cast<int64_t>(kv.value.size())});
1035+
static_cast<int64_t>(kv.value.size()), ""});
10361036
keys.emplace_back(kv.key);
10371037
}
10381038

@@ -1168,7 +1168,7 @@ tl::expected<void, ErrorCode> StorageBackendAdaptor::ScanMeta(
11681168
keys.emplace_back(std::move(kv.key));
11691169
metas.emplace_back(StorageObjectMetadata{
11701170
-1, 0, (int64_t)keys.back().size(),
1171-
static_cast<int64_t>(kv.value.size())});
1171+
static_cast<int64_t>(kv.value.size()), ""});
11721172

11731173
if ((int64_t)keys.size() >=
11741174
file_storage_config_.scanmeta_iterator_keys_limit) {

mooncake-store/tests/pybind_client_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ TEST_F(RealClientTest, TestBatchAndNormalGetReplicaDesc) {
632632
std::span<const char> data_span(test_data.data(), test_data.size());
633633
ReplicateConfig config;
634634
config.replica_num = 1;
635-
int put_result = py_client_->put(key, data_span, config);
635+
py_client_->put(key, data_span, config);
636636
// test get_replica_desc
637637
std::vector<Replica::Descriptor> desc = py_client_->get_replica_desc(key);
638638
EXPECT_EQ(desc.size(), 1) << "get_replica_desc should return 1 desc";

0 commit comments

Comments
 (0)