Skip to content

Commit e77eb23

Browse files
Get rid of all fields from event DTO's we don't (currently) use.
Also add comment to event classes that are unused.
1 parent cebae9d commit e77eb23

File tree

12 files changed

+4
-34
lines changed

12 files changed

+4
-34
lines changed

webapp/src/DataTransferObject/Shadowing/Account.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44

55
class Account implements EventData
66
{
7-
7+
// Not used currently, so no fields
88
}

webapp/src/DataTransferObject/Shadowing/Award.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@
44

55
class Award implements EventData
66
{
7-
7+
// Not used currently, so no fields
8+
// TODO: verify awards?
89
}

webapp/src/DataTransferObject/Shadowing/ClarificationEvent.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ public function __construct(
88
public readonly string $id,
99
public readonly string $text,
1010
public readonly string $time,
11-
public readonly string $contestTime,
1211
public readonly ?string $fromTeamId,
1312
public readonly ?string $toTeamId,
1413
public readonly ?string $replyToId,

webapp/src/DataTransferObject/Shadowing/ContestData.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,10 @@ class ContestData
66
{
77
public function __construct(
88
public readonly string $id,
9-
public readonly ?string $externalId,
109
public readonly string $name,
11-
public readonly ?string $formalName,
12-
public readonly ?string $shortname,
1310
public readonly string $duration,
1411
public readonly ?string $scoreboardFreezeDuration,
15-
public readonly ?string $scoreboardThawTime,
16-
public readonly ?string $scoreboardType,
1712
public readonly int $penaltyTime,
1813
public readonly ?string $startTime,
19-
public readonly ?string $endTime,
20-
public readonly ?bool $allowSubmit,
21-
public readonly ?string $warningMessage,
2214
) {}
2315
}

webapp/src/DataTransferObject/Shadowing/GroupEvent.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ public function __construct(
88
public readonly string $id,
99
public readonly string $name,
1010
public readonly ?string $icpcId,
11-
public readonly ?string $type,
12-
public readonly ?string $location,
1311
public readonly ?bool $hidden,
1412
public readonly ?int $sortorder,
1513
public readonly ?string $color,

webapp/src/DataTransferObject/Shadowing/JudgementEvent.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,9 @@ class JudgementEvent implements EventData
66
{
77
public function __construct(
88
public readonly string $startTime,
9-
public readonly string $startContestTime,
109
public readonly string $id,
1110
public readonly string $submissionId,
12-
public readonly ?float $maxRunTime,
1311
public readonly ?string $endTime,
14-
public readonly ?string $outputCompileAsString,
1512
public readonly ?string $judgementTypeId,
1613
) {}
1714
}

webapp/src/DataTransferObject/Shadowing/LanguageEvent.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,7 @@
44

55
class LanguageEvent implements EventData
66
{
7-
/**
8-
* @param string[] $extensions
9-
*/
107
public function __construct(
118
public readonly string $id,
12-
public readonly string $name,
13-
public readonly ?bool $entryPointRequired,
14-
public readonly ?string $entryPointName,
15-
public readonly array $extensions,
169
) {}
1710
}

webapp/src/DataTransferObject/Shadowing/OrganizationEvent.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,5 @@ public function __construct(
1010
public readonly ?string $icpcId,
1111
public readonly ?string $formalName,
1212
public readonly ?string $country,
13-
public readonly ?string $url,
14-
public readonly ?string $twitterHashtag,
15-
public readonly ?string $twitterAccount,
1613
) {}
1714
}

webapp/src/DataTransferObject/Shadowing/RunEvent.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ public function __construct(
1010
public readonly int $ordinal,
1111
public readonly ?string $judgementTypeId,
1212
public readonly ?string $time,
13-
public readonly ?string $contestTime,
1413
public readonly ?float $runTime,
1514
) {}
1615
}

webapp/src/DataTransferObject/Shadowing/StateEvent.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@
55
class StateEvent implements EventData
66
{
77
public function __construct(
8-
public readonly ?string $started,
9-
public readonly ?string $ended,
10-
public readonly ?string $frozen,
11-
public readonly ?string $thawed,
12-
public readonly ?string $finalized,
138
public readonly ?string $endOfUpdates,
149
) {}
1510
}

0 commit comments

Comments
 (0)